perf_hooks: ignore duplicated entries in observer#29442
Closed
fanatid wants to merge 1 commit intonodejs:masterfrom
Closed
perf_hooks: ignore duplicated entries in observer#29442fanatid wants to merge 1 commit intonodejs:masterfrom
fanatid wants to merge 1 commit intonodejs:masterfrom
Conversation
PerformanceObserver should add to observing only unique entry types.
nodejs-github-bot
added
the
perf_hooks
devnexen
approved these changes
Sep 5, 2019
JungMinu
approved these changes
Sep 6, 2019
Collaborator
Trott
added
the
author ready
Collaborator
Member
|
Landed in ef9ecfb |
Trott
pushed a commit
that referenced
this pull request
Sep 7, 2019
PerformanceObserver should add to observing only unique entry types. PR-URL: #29442 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
PerformanceObserver should add to observing only unique entry types. PR-URL: #29442 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Merged
This was referenced Sep 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PerformanceObserver should add to observing only unique entry types.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes