lib: remove the use of util.isFunction#29566
Closed
himself65 wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
himself65
force-pushed
the
isFunction
branch
from
2318ad8 to
348d0ab
Compare
nodejs-github-bot
added
the
inspector
targos
approved these changes
Sep 15, 2019
ZYSzys
approved these changes
Sep 15, 2019
Collaborator
Contributor
|
@himself65 Do we have a way to check the coverage and match it against the list of deprecated api? How did you stumble upon this anyways ? |
Member
Author
|
@shobhitchittora I wanted to write something in |
cjihrig
approved these changes
Sep 15, 2019
Trott
approved these changes
Sep 15, 2019
Trott
added
the
author ready
jasnell
approved these changes
Sep 16, 2019
trivikr
approved these changes
Sep 17, 2019
lpinca
approved these changes
Sep 17, 2019
Member
|
This needs a rebase. |
Collaborator
Member
|
Rebased and force-pushed to remove commit that had been force-pushed over on master earlier today, and also to remove the merge commit (which CI fails on). |
Collaborator
Member
Author
|
yeah, i know but recently i have no PC :(
获取 Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
发件人: Rich Trott <notifications@github.com>
发送时间: Wednesday, September 18, 2019 7:41:33 AM
收件人: nodejs/node <node@noreply.github.com>
抄送: 扩散性百万甜面包 <himself65@outlook.com>; Mention <mention@noreply.github.com>
主题: Re: [nodejs/node] lib: remove the use of util.isFunction (#29566)
Rebased and force-pushed to remove commit that had been force-pushed over on master earlier today, and also to remove the merge commit (which CI fails on).
―
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#29566?email_source=notifications&email_token=ADLAM6FV2M3ETOUQYWQB3XLQKFTK3A5CNFSM4IW2RZF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD66G2RQ#issuecomment-532442438>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADLAM6AQF5R4LK7SAQLKLQDQKFTK3ANCNFSM4IW2RZFQ>.
|
Member
Yeah, no problem, I did it already, I was just documenting that I did that. Restarted tests and if they pass, this is ready to land. |
Member
Author
|
thanks a lot
获取 Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
发件人: Rich Trott <notifications@github.com>
发送时间: Wednesday, September 18, 2019 7:49:58 AM
收件人: nodejs/node <node@noreply.github.com>
抄送: 扩散性百万甜面包 <himself65@outlook.com>; Mention <mention@noreply.github.com>
主题: Re: [nodejs/node] lib: remove the use of util.isFunction (#29566)
yeah, i know but recently i have no PC :(
Yeah, no problem, I did it already, I was just documenting that I did that. Restarted tests and if they pass, this is ready to land.
―
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#29566?email_source=notifications&email_token=ADLAM6AIX6BDV5PL5TXB4H3QKFUKNA5CNFSM4IW2RZF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD66HHNA#issuecomment-532444084>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADLAM6F3D3KJDI75J62SD3DQKFUKNANCNFSM4IW2RZFQ>.
|
Collaborator
Trott
pushed a commit
that referenced
this pull request
Sep 18, 2019
PR-URL: #29566 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
|
Landed in 7fa03b5 |
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
PR-URL: #29566 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 25, 2019
PR-URL: #29566 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Sep 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://nodejs.org/dist/latest-v12.x/docs/api/util.html#util_util_isfunction_object
util.isFunctionhas deprecated.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes