build: test Python 3.7 on Travis CI AGAIN#29985
Closed
Conversation
Reimplement #29451 on the master branch
nodejs-github-bot
added
the
build
cclauss
requested review from
Trott,
bnoordhuis,
richardlau,
rvagg and
sam-github
richardlau
reviewed
Oct 15, 2019
.travis.yml
Outdated
| # - PYTHON_VERSION="3.7.1" | ||
| - PYTHON_VERSION="3.7.1" | ||
| - PYTHON=python3 | ||
| - EXPERIMENTAL_NODE_GYP_PYTHON3="yes" |
Member
There was a problem hiding this comment.
I forget, is EXPERIMENTAL_NODE_GYP_PYTHON3 still required for node-gyp 5.x?
.travis.yml
Outdated
| @@ -10,9 +10,11 @@ language: cpp | |||
| # To experiment with Python 3, comment out Python 2.7 and uncomment one of the Python 3 versions. | |||
Member
There was a problem hiding this comment.
I don't mind switching the Python on Travis to Python 3 (assuming everything works). If so this comment can go.
cclauss
added
the
python
Contributor
|
Looked like some travis failures: |
3 tasks
Contributor
Author
|
Closing in favor of #29451 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reimplement #29451 on the master branch
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes