Skip to content

[v10.x backport] lib: fix comment nits in bootstrap\loaders.js #30338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GaryGSC wants to merge 1 commit into from
Closed

[v10.x backport] lib: fix comment nits in bootstrap\loaders.js #30338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
lib: fix comment nits in bootstrap\loaders.js 
Backport-PR-URL: #30338

PR-URL: #24641
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

(cherry picked from commit 1db808c)
  • Loading branch information
@vsemozhetbyt @GaryGSC
vsemozhetbyt authored and GaryGSC committed Nov 8, 2019
commit e37212fefe4bb27cb456eb487f48089897b6825a
22 changes: 11 additions & 11 deletions lib/internal/bootstrap/loaders.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
// can be created using NODE_MODULE_CONTEXT_AWARE_CPP() with the flag
// NM_F_LINKED.
// - internalBinding(): the private internal C++ binding loader, inaccessible
// from user land because they are only available from NativeModule.require()
// from user land because they are only available from NativeModule.require().
// These C++ bindings are created using NODE_MODULE_CONTEXT_AWARE_INTERNAL()
// and have their nm_flags set to NM_F_INTERNAL.
//
Expand Down Expand Up @@ -61,7 +61,7 @@
keys: ObjectKeys,
} = Object;

// Set up process.moduleLoadList
// Set up process.moduleLoadList.
const moduleLoadList = [];
ObjectDefineProperty(process, 'moduleLoadList', {
value: moduleLoadList,
Expand All @@ -70,7 +70,7 @@
writable: false
});

// Set up process.binding() and process._linkedBinding()
// Set up process.binding() and process._linkedBinding().
{
const bindingObj = ObjectCreate(null);

Expand All @@ -93,7 +93,7 @@
};
}

// Set up internalBinding() in the closure
// Set up internalBinding() in the closure.
let internalBinding;
{
const bindingObj = ObjectCreate(null);
Expand All @@ -115,11 +115,11 @@
};
}

// Create this WeakMap in js-land because V8 has no C++ API for WeakMap
// Create this WeakMap in js-land because V8 has no C++ API for WeakMap.
internalBinding('module_wrap').callbackMap = new WeakMap();
const { ContextifyScript } = process.binding('contextify');

// Set up NativeModule
// Set up NativeModule.
function NativeModule(id) {
this.filename = `${id}.js`;
this.id = id;
Expand All @@ -128,7 +128,7 @@
this.exportKeys = undefined;
this.loaded = false;
this.loading = false;
this.script = null; // The ContextifyScript of the module
this.script = null; // The ContextifyScript of the module.
}

NativeModule._source = getBinding('natives');
Expand Down Expand Up @@ -160,7 +160,7 @@
if (!NativeModule.exists(id)) {
// Model the error off the internal/errors.js model, but
// do not use that module given that it could actually be
// the one causing the error if there's a bug in Node.js
// the one causing the error if there's a bug in Node.js.
// eslint-disable-next-line no-restricted-syntax
const err = new Error(`No such built-in module: ${id}`);
err.code = 'ERR_UNKNOWN_BUILTIN_MODULE';
Expand Down Expand Up @@ -201,15 +201,15 @@

if (config.exposeInternals) {
NativeModule.nonInternalExists = function(id) {
// Do not expose this to user land even with --expose-internals
// Do not expose this to user land even with --expose-internals.
if (id === loaderId) {
return false;
}
return NativeModule.exists(id);
};

NativeModule.isInternal = function(id) {
// Do not expose this to user land even with --expose-internals
// Do not expose this to user land even with --expose-internals.
return id === loaderId;
};
} else {
Expand Down Expand Up @@ -243,7 +243,7 @@
};

// Provide named exports for all builtin libraries so that the libraries
// may be imported in a nicer way for esm users. The default export is left
// may be imported in a nicer way for ESM users. The default export is left
// as the entire namespace (module.exports) and wrapped in a proxy such
// that APMs and other behavior are still left intact.
NativeModule.prototype.proxifyExports = function() {
Expand Down