Skip to content

src: remove unused sync result from ASYNC_CALL #3049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skomski wants to merge 1 commit into from
Closed

src: remove unused sync result from ASYNC_CALL #3049

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: fix u-a-free if uv returns err in ASYNC_CALL
  • Loading branch information
@skomski
skomski committed Sep 26, 2015
commit 95950253defa9052301b5b5a311ca85fdc377542
7 changes: 5 additions & 2 deletions src/node_file.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,10 @@ struct fs_req_wrap {
uv_req->result = err; \
uv_req->path = nullptr; \
After(uv_req); \
Copy link
Member

@bnoordhuis bnoordhuis Sep 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you set req_wrap = nullptr here?

Aside: the uv_req->path = nullptr is a memory leak waiting to happen. It's mostly benign now - I think.

} \
args.GetReturnValue().Set(req_wrap->persistent());
req_wrap = nullptr; \
} else { \
args.GetReturnValue().Set(req_wrap->persistent()); \
}

#define ASYNC_CALL(func, req, ...) \
ASYNC_DEST_CALL(func, req, nullptr, __VA_ARGS__) \
Expand Down Expand Up @@ -1028,6 +1030,7 @@ static void WriteString(const FunctionCallbackInfo<Value>& args) {
uv_req->result = err;
uv_req->path = nullptr;
After(uv_req);
return;
}

return args.GetReturnValue().Set(req_wrap->persistent());
Expand Down