Skip to content

stream: fix finished writable/readable state #31527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 2 commits into from
Closed

stream: fix finished writable/readable state #31527

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4284859
stream: fix finished writable/readable state
ronag Jan 26, 2020
818e972
fixup: add Readdable test
ronag Jan 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: add Readdable test
  • Loading branch information
@ronag
ronag committed Jan 26, 2020
commit 818e972f7d73620795c69f781b9eabac69805326
9 changes: 9 additions & 0 deletions test/parallel/test-stream-finished.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,3 +193,12 @@ const { promisify } = require('util');
assert.strictEqual(err.code, 'ERR_STREAM_PREMATURE_CLOSE');
}));
}

{
const readable = new Readable();
readable.readable = false;
readable.destroy();
finished(readable, common.mustCall((err) => {
assert.strictEqual(err.code, 'ERR_STREAM_PREMATURE_CLOSE');
}));
}