fs: fix valid id range on chown, lchown, fchown#31694
Closed
himself65 wants to merge 1 commit intonodejs:masterfrom
Closed
fs: fix valid id range on chown, lchown, fchown#31694himself65 wants to merge 1 commit intonodejs:masterfrom
himself65 wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
fs
himself65
force-pushed
the
31673
branch
3 times, most recently
from
5deeef9 to
a19201f
Compare
addaleax
approved these changes
Feb 8, 2020
Collaborator
BridgeAR
approved these changes
Feb 9, 2020
Member
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
Functionality wise it's LGTM but the code could be simplified.
himself65
force-pushed
the
31673
branch
3 times, most recently
from
5802f9b to
01df5b3
Compare
jasnell
reviewed
Feb 10, 2020
addaleax
approved these changes
Feb 10, 2020
jasnell
approved these changes
Feb 10, 2020
addaleax
reviewed
Feb 10, 2020
addaleax
added
the
author ready
Collaborator
ZYSzys
approved these changes
Feb 14, 2020
Collaborator
addaleax
pushed a commit
that referenced
this pull request
Mar 9, 2020
PR-URL: #31694 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Member
|
Landed in 0a539dd |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2020
PR-URL: #31694 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
PR-URL: #31694 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 23, 2020
PR-URL: #31694 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Mar 30, 2020
PR-URL: #31694 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
RaisinTen
added a commit
to RaisinTen/node
that referenced
this pull request
Mar 31, 2021
This syncs the type assertion introduced in the referenced PR in the C++ side. Since chown, lchown, and fchown can accept -1 as a value for uid and gid, we should also accept signed integers from the JS side. Fixes: nodejs#37995 Refs: nodejs#31694
Closed
Trott
pushed a commit
that referenced
this pull request
Apr 3, 2021
This syncs the type assertion introduced in the referenced PR in the C++ side. Since chown, lchown, and fchown can accept -1 as a value for uid and gid, we should also accept signed integers from the JS side. Fixes: #37995 Refs: #31694 PR-URL: #38004 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 4, 2021
This syncs the type assertion introduced in the referenced PR in the C++ side. Since chown, lchown, and fchown can accept -1 as a value for uid and gid, we should also accept signed integers from the JS side. Fixes: #37995 Refs: #31694 PR-URL: #38004 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 5, 2021
This syncs the type assertion introduced in the referenced PR in the C++ side. Since chown, lchown, and fchown can accept -1 as a value for uid and gid, we should also accept signed integers from the JS side. Fixes: #37995 Refs: #31694 PR-URL: #38004 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
This syncs the type assertion introduced in the referenced PR in the C++ side. Since chown, lchown, and fchown can accept -1 as a value for uid and gid, we should also accept signed integers from the JS side. Fixes: #37995 Refs: #31694 PR-URL: #38004 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #31673
related:
http://man7.org/linux/man-pages/man2/chown.2.html
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes