Skip to content

Refactor benchmark and add no-var eslint rule #31794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dnlup wants to merge 11 commits into from
Closed

Refactor benchmark and add no-var eslint rule #31794

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7acb1b1
benchmark: add `no-var` rule in .eslintrc.yaml
dnlup Feb 14, 2020
4253737
benchmark: use const instead of var in async_hooks
dnlup Feb 14, 2020
1162d9c
benchmark: use let instead of var in common.js
dnlup Feb 14, 2020
3e0e71b
benchmark: use let instead of var in dns
dnlup Feb 14, 2020
295111d
benchmark: use let instead of var in run.js
dnlup Feb 14, 2020
08cf239
benchmark: use let instead of var in timers
dnlup Feb 14, 2020
0991d53
benchmark: use let instead of var in tls
dnlup Feb 14, 2020
98849b8
benchmark: use let instead of var in url
dnlup Feb 14, 2020
4444d3b
benchmark: use let instead of var in util
dnlup Feb 14, 2020
58ab254
benchmark: use let instead of var in worker
dnlup Feb 14, 2020
ce9f93e
benchmark: use let instead of var in zlib
dnlup Feb 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
benchmark: use let instead of var in dns
  • Loading branch information
@dnlup
dnlup committed Feb 14, 2020
commit 3e0e71b1a30de3d2d164f2602b82972cda8b9725
2 changes: 1 addition & 1 deletion benchmark/dns/lookup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const bench = common.createBenchmark(main, {
});

function main({ name, n, all }) {
var i = 0;
let i = 0;

if (all === 'true') {
const opts = { all: true };
Expand Down