test: Worker initialization failure test case by HarshithaKP · Pull Request #31929 · nodejs/node

HarshithaKP · 2020-02-24T07:37:39Z

Cover the scenario fixed through
#31621
Unfortunately there is no easy way to test this, in a
cross-platform manner. So the approach is:

open a child process with ulimit restriction on file descriptors
in the child process, start few workers - more than the fd limit
make sure some workers fail, with the expected error type.
skip the test in windows, as there is no ulimit there.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Cover the scenario fixed through nodejs#31621 Unfortunately there is no easy way to test this, in a cross-platform manner. So the approach is: - open a child process with ulimit restriction on file descriptors - in the child process, start few workers - more than the fd limit - make sure some workers fail, with the expected error type. - skip the test in windows, as there is no ulimit there.

Trott · 2020-02-24T11:33:06Z

test/parallel/test-worker-init-failure.js

+  }
+
+  // Limit the number of open files, to force workers to fail
+  let testCmd = 'ulimit -n 128 && ';


Any reason not to go with something much smaller than 128, like maybe 8?

@Trott, When I ran a simple node.js code, it created 30+ file descriptors. If I reduce the fd count to 8, it fails at arbitrary point without / before reaching worker creation.

Trott · 2020-02-24T11:38:35Z

test/parallel/test-worker-init-failure.js

+} else {
+
+  if (common.isWindows) {
+    common.skip('ulimit does not work on Windows.');


Maybe instead of skipping the test, just skip the ulimit prefix? As written, I don't think the test won't fail if the error event never happens, so the test might still be runnable under Windows?

don't think the test won't fail if the error event never happens

I think this is an error in the test and therefore after it is resolved it will no longer be runnable on windows.
Also, it doesn't look like there is any equivalent for ulimit on windows so skip looks like the only way.

@Trott , with respect to Windows - is there any merit in running a test that doesn't make any assertion ?

test/parallel/test-worker-init-failure.js

Trott

The test still passes when the child process errors.

test/parallel/test-worker-init-failure.js

Trott · 2020-02-25T14:01:20Z

Locally, this test is failing for me. The error message I'm getting is EMFILE: too many open files, uv_cwd and not Worker initialization failure: EMFILE.

Running CI to see if there are similar problems there or not.....

nodejs-github-bot · 2020-02-25T14:01:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29342/

issue addressed

Trott · 2020-02-25T15:08:01Z

AIX failed in CI (and there may be others as CI isn't finished at the time of this writing) and sure enough it failed with the 1 != 0 message, so maybe we can make the error message more informative and then re-run.

test/parallel/test-worker-init-failure.js

nodejs-github-bot · 2020-03-05T06:57:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29560/

nodejs-github-bot · 2020-03-11T11:31:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29725/

lundibundi · 2020-03-11T11:34:03Z

test/parallel/test-worker-init-failure.js

+} else {
+  // Limit the number of open files, to force workers to fail.
+  let testCmd = `ulimit -n ${OPENFILES} && `;
+


Nit:

Suggested change

@lundibundi, thanks. Removed the extra line.

lundibundi · 2020-03-11T11:35:55Z

ping @Trott @nodejs/testing @nodejs/workers.

test/parallel/test-worker-init-failure.js

nodejs-github-bot · 2020-03-11T15:37:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29731/

nodejs-github-bot · 2020-04-05T18:28:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30453/

nodejs-github-bot · 2020-04-05T20:57:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30476/

addaleax · 2020-04-05T23:52:30Z

Landed in 5b899d6

Cover the scenario fixed through #31621 Unfortunately there is no easy way to test this, in a cross-platform manner. So the approach is: - open a child process with ulimit restriction on file descriptors - in the child process, start few workers - more than the fd limit - make sure some workers fail, with the expected error type. - skip the test in windows, as there is no ulimit there. Refs: #31621 PR-URL: #31929 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 24, 2020

fixup: remove unwanted file

500e991

Trott reviewed Feb 24, 2020

View reviewed changes

test/parallel/test-worker-init-failure.js Outdated Show resolved Hide resolved

Trott previously requested changes Feb 24, 2020

View reviewed changes

lundibundi reviewed Feb 24, 2020

View reviewed changes

fixup: address review comments

313d520

Trott reviewed Feb 25, 2020

View reviewed changes

test/parallel/test-worker-init-failure.js Show resolved Hide resolved

lundibundi reviewed Feb 25, 2020

View reviewed changes

test/parallel/test-worker-init-failure.js Show resolved Hide resolved

test/parallel/test-worker-init-failure.js Outdated Show resolved Hide resolved

test/parallel/test-worker-init-failure.js Outdated Show resolved Hide resolved

HarshithaKP added 2 commits February 26, 2020 01:15

fixup: address review comments

44042ca

fixup: cover EMFILE failures generically

6a7f905

lundibundi reviewed Feb 26, 2020

View reviewed changes

test/parallel/test-worker-init-failure.js Show resolved Hide resolved

HarshithaKP added 2 commits February 27, 2020 04:41

fixup: address review comment

6a6efb9

fixup: address review comment

d356e7e

lundibundi approved these changes Mar 11, 2020

View reviewed changes

addaleax reviewed Mar 11, 2020

View reviewed changes

test/parallel/test-worker-init-failure.js Show resolved Hide resolved

test/parallel/test-worker-init-failure.js Show resolved Hide resolved

HarshithaKP added 2 commits March 11, 2020 08:58

fixup: address review comments

520a906

fixup: address review comment

1c804df

addaleax approved these changes Apr 5, 2020

View reviewed changes

addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 5, 2020

addaleax closed this Apr 5, 2020

targos mentioned this pull request Apr 13, 2020

v13.13.0 release proposal #32813

Merged

targos mentioned this pull request Apr 22, 2020

v12.16.3 release proposal #33009

Merged

yurynix mentioned this pull request Jun 13, 2023

Spawn a new worker when an old one is stopped allegro/node-worker-nodes#62

Merged

Uh oh!

Conversation

HarshithaKP commented Feb 24, 2020

Checklist

Uh oh!

Trott Feb 24, 2020

Choose a reason for hiding this comment

Uh oh!

HarshithaKP Feb 25, 2020

Choose a reason for hiding this comment

Uh oh!

Trott Feb 24, 2020

Choose a reason for hiding this comment

Uh oh!

lundibundi Feb 24, 2020

Choose a reason for hiding this comment

Uh oh!

HarshithaKP Feb 25, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Trott left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Trott commented Feb 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Feb 25, 2020

Uh oh!

Trott commented Feb 25, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Mar 5, 2020

Uh oh!

nodejs-github-bot commented Mar 11, 2020

Uh oh!

lundibundi Mar 11, 2020

Choose a reason for hiding this comment

Uh oh!

HarshithaKP Mar 11, 2020

Choose a reason for hiding this comment

Uh oh!

lundibundi commented Mar 11, 2020

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Mar 11, 2020

Uh oh!

nodejs-github-bot commented Apr 5, 2020

Uh oh!

nodejs-github-bot commented Apr 5, 2020

Uh oh!

addaleax commented Apr 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Trott commented Feb 25, 2020 •

edited

Loading