lib: replace charCodeAt with fixed Unicode#32758
lib: replace charCodeAt with fixed Unicode#32758rickyes wants to merge 2 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
console
|
Can you explain what the motivation here is? If the goal is avoiding a few calls to |
@addaleax Yes, in order to avoid unnecessary calls to |
|
@addaleax Or we can move to // Alphabet chars.
CHAR_UPPERCASE_A: 65, /* A */
CHAR_LOWERCASE_A: 97, /* a */
CHAR_UPPERCASE_Z: 90, /* Z */
CHAR_LOWERCASE_Z: 122, /* z */
CHAR_UPPERCASE_C: 67, /* C */
CHAR_LOWERCASE_B: 98, /* b */
CHAR_LOWERCASE_E: 101, /* e */
CHAR_LOWERCASE_N: 110, /* n */ |
|
@rickyes Yeah, I guess that would be consistent… I’m good with that 👍 I’m also good with doing nothing and keeping the code as straightforward as possible. |
done. |
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
I would rather keep the code as it is right now but I won't block this, since other collaborators seem to agree with this change.
|
I feel the same way as @BridgeAR. |
|
@jasnell @lpinca @trivikr @himself65 PTAL: it would be good to get some feedback about the mentioned concerns. |
|
agree with that |
|
Not sure what the concerns are @BridgeAR ... this LGTM |
BridgeAR
force-pushed
the
master
branch
2 times, most recently
from
8ae28ff to
2935f72
Compare
PR-URL: #32758 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
|
Landed in 9918bdf |
PR-URL: #32758 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
PR-URL: #32758 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
PR-URL: #32758 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
PR-URL: #32758 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
PR-URL: #32758 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
8 participants
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes