Skip to content

src: fix invalid windowBits=8 gzip segfault #33045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bnoordhuis wants to merge 5 commits into from
Closed

src: fix invalid windowBits=8 gzip segfault #33045

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9436534
src: fix invalid windowBits=8 gzip segfault
bnoordhuis Apr 24, 2020
1cec86e
zlib: reject windowBits=8 when mode=GZIP
bnoordhuis Apr 24, 2020
4de03b1
fixup! zlib: reject windowBits=8 when mode=GZIP
addaleax May 7, 2020
40da66d
fixup! src: fix invalid windowBits=8 gzip segfault
addaleax May 7, 2020
61b08c3
fixup! zlib: reject windowBits=8 when mode=GZIP
addaleax May 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! zlib: reject windowBits=8 when mode=GZIP 
Co-authored-by: Jiawen Geng <technicalcute@gmail.com>
  • Loading branch information
@addaleax @gengjiawen
addaleax and gengjiawen authored May 8, 2020
commit 61b08c3293e0c4b0c87067722b129ccbdd8884ed
2 changes: 1 addition & 1 deletion lib/zlib.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,7 @@ function Zlib(opts, mode) {
mode === UNZIP)) {
windowBits = 0;
} else {
// `{ windowBits: 8 }` is valid for deflate but nog gzip.
// `{ windowBits: 8 }` is valid for deflate but not gzip.
const min = Z_MIN_WINDOWBITS + (mode === GZIP ? 1 : 0);
windowBits = checkRangesOrGetDefault(
opts.windowBits, 'options.windowBits',
Expand Down