Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove env var
  • Loading branch information
guybedford committed Apr 30, 2020
commit 766465a7beea80711103c47357766acf21d20be6
3 changes: 1 addition & 2 deletions doc/api/cli.md
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,7 @@ added: REPLACEME

> Stability: 1 - Experimental

Enables the `"development"` [conditional export][] in package resolution,
while also setting `process.env.NODE_ENV` to `"development"`.
Enables the `"development"` [conditional export][] in package resolution.

### `--disable-proto=mode`
<!--YAML
Expand Down
2 changes: 1 addition & 1 deletion doc/node.1
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ File name of the V8 CPU profile generated with
.Fl -cpu-prof
.
.It Fl -dev
Sets the development exports resolution and NODE_ENV environment variable.
Enables the development mode conditional exports resolution.
.
.It Fl -disable-proto Ns = Ns Ar mode
Disable the `Object.prototype.__proto__` property. If
Expand Down
3 changes: 0 additions & 3 deletions lib/internal/bootstrap/pre_execution.js
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,6 @@ function initializeReport() {
}

function setupDebugEnv() {
if (getOptionValue('--dev')) {
process.env.NODE_ENV = 'development';
}
require('internal/util/debuglog').initializeDebugEnv(process.env.NODE_DEBUG);
if (getOptionValue('--expose-internals')) {
require('internal/bootstrap/loaders').NativeModule.exposeInternals();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ const dev = process.env.NODE_ENV === 'development';

export async function resolve(specifier, context, defaultResolve) {
ok(Array.isArray(context.conditions), 'loader receives conditions array');
deepStrictEqual([...context.conditions].sort(),
['import', 'node', ...dev ? ['development'] : []]);
deepStrictEqual(
[...context.conditions].filter(c => c !== 'development').sort(),
['import', 'node']
);
return defaultResolve(specifier, {
...context,
conditions: ['custom-condition', ...context.conditions],
Expand Down
15 changes: 5 additions & 10 deletions test/fixtures/pkgexports-dev.mjs
Original file line number Diff line number Diff line change
@@ -1,17 +1,12 @@
import { fileURLToPath } from 'url';
import { createRequire } from 'module';
import { strictEqual } from 'assert';
import { strictEqual, AssertionError } from 'assert';

const require = createRequire(fileURLToPath(import.meta.url));

const expectValue =
process.env.NODE_ENV === 'development' ? 'development' : 'production';

strictEqual(require('pkgexports-dev'), expectValue);
const requireVal = require('pkgexports-dev');

(async () => {
const { default: value } = await import('pkgexports-dev');
strictEqual(value, expectValue);

console.log(expectValue);
const { default: importVal } = await import('pkgexports-dev');
strictEqual(requireVal, importVal);
console.log(importVal);
})();