Skip to content

quic: skip test-quic-preferred-address-ipv6.js when no ipv6#33919

Closed
jasnell wants to merge 1 commit intonodejs:masterfrom
jasnell:skip-quic-test-when-no-ipv6
Closed

quic: skip test-quic-preferred-address-ipv6.js when no ipv6#33919
jasnell wants to merge 1 commit intonodejs:masterfrom
jasnell:skip-quic-test-when-no-ipv6

Conversation

@jasnell
Copy link
Member

@jasnell jasnell commented Jun 17, 2020

/cc @addaleax

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 17, 2020
@jasnell jasnell mentioned this pull request Jun 17, 2020
Closed
2 tasks
@jasnell
Copy link
Member Author

jasnell commented Jun 17, 2020

CI: https://ci.nodejs.org/job/node-test-commit/39062/

@gengjiawen
Copy link
Member

gengjiawen commented Jun 17, 2020

Looks like timeout on multi platform
https://ci.nodejs.org/job/node-test-commit-osx/nodes=osx1014/34734/console

11:00:22 not ok 2952 sequential/test-quic-preferred-address-ipv6
11:00:22   ---
11:00:22   duration_ms: 120.144
11:00:22   severity: fail
11:00:22   exitcode: -15
11:00:22   stack: |-
11:00:22     timeout

@jasnell
Copy link
Member Author

jasnell commented Jun 17, 2020

@gengjiawen ... yeah, I believe that's a separate issue from this one that I will work on fixing separately. I'm not able to recreate that problem locally so it may take some time.

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 17, 2020
@jasnell
Copy link
Member Author

jasnell commented Jun 17, 2020

@nodejs/quic ... fast track?

@jasnell jasnell added the quic Issues and PRs related to the QUIC implementation / HTTP/3. label Jun 17, 2020
jasnell added a commit that referenced this pull request Jun 17, 2020
@jasnell
quic: skip test-quic-preferred-address-ipv6.js when no ipv6
272b46e 
PR-URL: #33919
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Jun 17, 2020

Landed in 272b46e

@jasnell jasnell closed this Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@richardlau richardlau richardlau approved these changes

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. quic Issues and PRs related to the QUIC implementation / HTTP/3. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jasnell @gengjiawen @addaleax @richardlau @codebytere @nodejs-github-bot