Skip to content

Exit after printing v8 help #34135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ulan wants to merge 1 commit into from
Closed

Exit after printing v8 help #34135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Exit after printing v8 help 
V8 es not exit the process after handling --help anymore:
https://chromium-review.googlesource.com/c/v8/v8/+/2276276
  • Loading branch information
@ulan
ulan committed Jun 30, 2020
commit 071b31808e7af2d2fc0b573afc70769e7514bcb1
3 changes: 1 addition & 2 deletions src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,9 +939,8 @@ void Init(int* argc,
}

if (per_process::cli_options->print_v8_help) {
// Doesn't return.
V8::SetFlagsFromString("--help", static_cast<size_t>(6));
UNREACHABLE();
exit(0);
}

*argc = argv_.size();
Expand Down