Skip to content

[v14.x] deps: update V8 to 8.4 #34356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 21 commits into from
Closed

[v14.x] deps: update V8 to 8.4 #34356

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
101a4e5
deps: update V8 to 8.4.371.19
targos Jul 14, 2020
d0a3a41
build: reset embedder string to "-node.0"
targos Jul 14, 2020
8be298d
deps: V8: un-cherry-pick bd019bd
refack Mar 27, 2019
332374e
deps: patch V8 to run on older XCode versions
ryzokuken Sep 14, 2019
dc9a411
deps: V8: patch register-arm64.h
refack May 22, 2019
b27fe7e
deps: V8: forward declaration of `Rtl*FunctionTable`
refack May 22, 2019
f997e43
deps: make v8.h compatible with VS2015
joaocgreis Nov 1, 2019
183e0ae
deps: V8: silence irrelevant warnings
targos Mar 27, 2019
722f765
deps: patch V8 to run on Xcode 8
mmarchini Mar 10, 2020
65af1a7
deps: V8: cherry-pick 9868b2aefa1a
targos Jun 2, 2020
43c1e9f
deps: V8: fix compilation on VS2017
gengjiawen Jun 2, 2020
b949068
deps: V8: backport 22014de00115
joyeecheung May 29, 2020
4ab20df
deps: V8: cherry-pick eec10a2fd8fa
Qard Jun 6, 2020
64dcfc7
deps: update V8 postmortem metadata script
cjihrig Jul 4, 2020
da92783
tools: update V8 gypfiles for 8.4
ryzokuken Apr 17, 2020
6dec877
deps: bump minimum icu version to 67
targos May 9, 2020
dd1f4e7
test: remove test/v8-updates/test-postmortem-metadata.js
cjihrig Jun 29, 2020
2362639
deps: V8: undo header change of 9dbab9bbdb979
addaleax Jul 14, 2020
c940cb7
deps: V8: re-add dummy Isolate::CheckMemoryPressure
addaleax Jul 14, 2020
4fcd9c2
deps: V8: revert de4c0042cbe6 from upstream V8
addaleax Jul 14, 2020
9ff6a3b
deps: V8: update headers for ABI compatibility
addaleax Jul 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tools: update V8 gypfiles for 8.4 
PR-URL: #33579
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
  • Loading branch information
@ryzokuken @targos
ryzokuken authored and targos committed Jul 16, 2020
commit da92783f8cf25b518424cf0aecf03135424c9c8f
25 changes: 20 additions & 5 deletions tools/v8_gypfiles/features.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,15 @@
# Enable lazy source positions by default.
'v8_enable_lazy_source_positions%': 1,

# Enable third party HEAP library
'v8_enable_third_party_heap%': 0,

# Libaries used by third party heap
'v8_third_party_heap_libs%': [],

# Source code used by third party heap
'v8_third_party_heap_files%': [],

# Disable write barriers when GCs are non-incremental and
# heap has single generation.
'v8_disable_write_barriers%': 0,
Expand All @@ -203,6 +212,10 @@
# for ARM64.
'v8_control_flow_integrity%': 0,

# Experimental support for native context independent code.
# https://crbug.com/v8/8888
'v8_enable_nci_code%': 0,

# Variables from v8.gni

# Enable ECMAScript Internationalization API. Enabling this feature will
Expand All @@ -228,10 +241,7 @@
'defines': ['V8_ENABLE_FUTURE',],
}],
['v8_enable_lite_mode==1', {
'defines': [
'V8_LITE_MODE',
'V8_JITLESS_MODE',
],
'defines': ['V8_LITE_MODE',],
}],
['v8_enable_gdbjit==1', {
'defines': ['ENABLE_GDB_JIT_INTERFACE',],
Expand Down Expand Up @@ -299,6 +309,9 @@
['v8_disable_write_barriers==1', {
'defines': ['V8_DISABLE_WRITE_BARRIERS',],
}],
['v8_enable_third_party_heap==1', {
'defines': ['V8_ENABLE_THIRD_PARTY_HEAP',],
}],
['v8_enable_concurrent_marking==1', {
'defines': ['V8_CONCURRENT_MARKING',],
}],
Expand Down Expand Up @@ -338,9 +351,11 @@
['v8_control_flow_integrity==1', {
'defines': ['V8_ENABLE_CONTROL_FLOW_INTEGRITY',],
}],
['v8_enable_nci_code==1', {
'defines': ['V8_ENABLE_NCI_CODE',],
}],
], # conditions
'defines': [
'V8_EMBEDDED_BUILTINS',
'V8_GYP_BUILD',
'V8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=<(v8_typed_array_max_size_in_heap)',
], # defines
Expand Down
22 changes: 21 additions & 1 deletion tools/v8_gypfiles/v8.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,12 @@
"<(V8_ROOT)/src/builtins/convert.tq",
"<(V8_ROOT)/src/builtins/console.tq",
"<(V8_ROOT)/src/builtins/data-view.tq",
"<(V8_ROOT)/src/builtins/finalization-registry.tq",
"<(V8_ROOT)/src/builtins/frames.tq",
"<(V8_ROOT)/src/builtins/frame-arguments.tq",
"<(V8_ROOT)/src/builtins/growable-fixed-array.tq",
"<(V8_ROOT)/src/builtins/ic-callable.tq",
"<(V8_ROOT)/src/builtins/ic.tq",
"<(V8_ROOT)/src/builtins/internal-coverage.tq",
"<(V8_ROOT)/src/builtins/iterator.tq",
"<(V8_ROOT)/src/builtins/math.tq",
Expand All @@ -55,6 +58,7 @@
"<(V8_ROOT)/src/builtins/promise-abstract-operations.tq",
"<(V8_ROOT)/src/builtins/promise-all.tq",
"<(V8_ROOT)/src/builtins/promise-all-element-closure.tq",
"<(V8_ROOT)/src/builtins/promise-any.tq",
"<(V8_ROOT)/src/builtins/promise-constructor.tq",
"<(V8_ROOT)/src/builtins/promise-finally.tq",
"<(V8_ROOT)/src/builtins/promise-misc.tq",
Expand Down Expand Up @@ -113,6 +117,7 @@
"<(V8_ROOT)/src/builtins/typed-array-sort.tq",
"<(V8_ROOT)/src/builtins/typed-array-subarray.tq",
"<(V8_ROOT)/src/builtins/typed-array.tq",
"<(V8_ROOT)/src/builtins/wasm.tq",
"<(V8_ROOT)/src/ic/handler-configuration.tq",
"<(V8_ROOT)/src/objects/allocation-site.tq",
"<(V8_ROOT)/src/objects/api-callbacks.tq",
Expand All @@ -131,6 +136,7 @@
"<(V8_ROOT)/src/objects/free-space.tq",
"<(V8_ROOT)/src/objects/heap-number.tq",
"<(V8_ROOT)/src/objects/heap-object.tq",
"<(V8_ROOT)/src/objects/js-aggregate-error.tq",
"<(V8_ROOT)/src/objects/js-array-buffer.tq",
"<(V8_ROOT)/src/objects/js-array.tq",
"<(V8_ROOT)/src/objects/js-collection-iterator.tq",
Expand Down Expand Up @@ -228,7 +234,7 @@
'<(torque_output_root)/torque-generated/class-verifiers-tq.h',
'<(torque_output_root)/torque-generated/enum-verifiers-tq.cc',
'<(torque_output_root)/torque-generated/objects-printer-tq.cc',
'<(torque_output_root)/torque-generated/objects-body-descriptors-tq-inl.h',
'<(torque_output_root)/torque-generated/objects-body-descriptors-tq-inl.inc',
'<(torque_output_root)/torque-generated/class-definitions-tq.cc',
'<(torque_output_root)/torque-generated/class-definitions-tq-inl.h',
'<(torque_output_root)/torque-generated/class-definitions-tq.h',
Expand Down Expand Up @@ -745,6 +751,13 @@
'<@(inspector_all_sources)',
],
'conditions': [
['v8_enable_third_party_heap==1', {
# TODO(targos): add values from v8_third_party_heap_files to sources
}, {
'sources': [
'<(V8_ROOT)/src/heap/third-party/heap-api-stub.cc',
],
}],
['want_separate_host_toolset', {
'toolsets': ['host', 'target'],
}],
Expand Down Expand Up @@ -885,6 +898,9 @@
['v8_postmortem_support', {
'dependencies': ['postmortem-metadata#target'],
}],
['v8_enable_third_party_heap', {
# TODO(targos): add values from v8_third_party_heap_libs to link_settings.libraries
}],
# Platforms that don't have Compare-And-Swap (CAS) support need to link atomic library
# to implement atomic memory access
['v8_current_cpu in ["mips", "mipsel", "mips64", "mips64el", "ppc", "arm"]', {
Expand Down Expand Up @@ -1226,6 +1242,8 @@
'<(V8_ROOT)/include/libplatform/v8-tracing.h',
'<(V8_ROOT)/src/libplatform/default-foreground-task-runner.cc',
'<(V8_ROOT)/src/libplatform/default-foreground-task-runner.h',
'<(V8_ROOT)/src/libplatform/default-job.cc',
'<(V8_ROOT)/src/libplatform/default-job.h',
'<(V8_ROOT)/src/libplatform/default-platform.cc',
'<(V8_ROOT)/src/libplatform/default-platform.h',
'<(V8_ROOT)/src/libplatform/default-worker-threads-task-runner.cc',
Expand Down Expand Up @@ -1583,6 +1601,8 @@
'<(V8_ROOT)/src/objects/instance-type.h',
'<(V8_ROOT)/src/objects/js-array-inl.h',
'<(V8_ROOT)/src/objects/js-array.h',
'<(V8_ROOT)/src/objects/js-aggregate-error-inl.h',
'<(V8_ROOT)/src/objects/js-aggregate-error.h',
'<(V8_ROOT)/src/objects/js-array-buffer-inl.h',
'<(V8_ROOT)/src/objects/js-array-buffer.h',
'<(V8_ROOT)/src/objects/js-objects-inl.h',
Expand Down