doc: mention triage in GOVERNANCE.md#34426
Closed
gireeshpunathil wants to merge 0 commit intonodejs:masterfrom
Closed
doc: mention triage in GOVERNANCE.md#34426gireeshpunathil wants to merge 0 commit intonodejs:masterfrom
gireeshpunathil wants to merge 0 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
meta
trivikr
approved these changes
Jul 19, 2020
Trott
reviewed
Jul 21, 2020
Trott
reviewed
Jul 21, 2020
Trott
approved these changes
Jul 21, 2020
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM. I know I'm the one that suggested putting triagers in this doc. Now I'm starting to wonder if it implies that Collaborators need to be Triagers first. I'm fine with putting it in here anyway. We can always remove it or modify it if it ends up causing any confusion. Perhaps it won't and I'm just overthinking things.
gireeshpunathil
force-pushed
the
governece-triage-link
branch
from
d5312a3 to
e8a462d
Compare
gireeshpunathil
added a commit
that referenced
this pull request
Jul 24, 2020
Refs: #34295 (comment) PR-URL: #34426 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <Michael_Dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
gireeshpunathil
force-pushed
the
governece-triage-link
branch
from
e8a462d to
adcf12c
Compare
Member
Author
|
landed in adcf12c |
MylesBorins
pushed a commit
that referenced
this pull request
Jul 27, 2020
Refs: #34295 (comment) PR-URL: #34426 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <Michael_Dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Refs: #34295 (comment) PR-URL: #34426 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <Michael_Dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Refs: #34295 (comment) PR-URL: #34426 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <Michael_Dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #34295 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes