build: define NODE_EXPERIMENTAL_QUIC in mkcodecache and node_mksnapshot by joyeecheung · Pull Request #34454 · nodejs/node

joyeecheung · 2020-07-21T01:43:14Z

build: define NODE_EXPERIMENTAL_QUIC in mkcodecache and node_mksnapshot

Otherwise the build would fail with
./configure --experimental-quic --ninja as the list of per-Environment
values would not match and the code cache builder would not generate
code cache for the quic JS sources. This is more or less a band-aid -
a proper fix would be to aggregate these flags into something
that can be included by all these different binary targets.
See #31074.

Fixes: #34435

Revert "src: refactor TimerWrap lifetime management"

This reverts commit 874460a.

@addaleax I have no idea why but it seems the TimerWrap lifetime management refactoring 874460a is also causing the build to fail a bunch of quic tests, crashing with

* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x40) frame #0: 0x000000010019c3c8 node`node::TimerWrapHandle::Stop() [inlined] node::TimerWrap::Stop(this=0x0000000000000000) at timer_wrap.cc:16:19 [opt] 13 } 14 15 void TimerWrap::Stop() { -> 16 if (timer_.data == nullptr) return; 17 uv_timer_stop(&timer_); 18 } 19

So I revereted it as well to make the tests pass

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes

tests and/or benchmarks are included

documentation is changed or added

commit message follows commit guidelines

nodejs-github-bot · 2020-07-21T01:44:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/32433/

joyeecheung · 2020-07-21T01:47:57Z

Custom build with --experimental-quic (pending) https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/15490/

jasnell · 2020-07-21T01:50:57Z

We should try to fix those reverts before landing this so we don't have to revert them. I'll be able to take a look tomorrow

Refs: nodejs#34454

addaleax · 2020-07-21T11:28:03Z

Not sure why this PR would expose something like this, but here’s a fix: #34460

jasnell · 2020-07-21T18:10:09Z

Once #34460 lands, the revert shouldn't be necessary and this otherwise LGTM

Refs: #34454 PR-URL: #34460 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

Otherwise the build would fail with `./configure --experimental-quic --ninja` as the list of per-Environment values would not match and the code cache builder would not generate code cache for the quic JS sources. This is more or less a band-aid - a proper fix would be to aggregate these flags into something that can be included by all these different binary targets. See nodejs#31074.

joyeecheung · 2020-07-22T03:44:58Z

Rebased. @nodejs/quic PTAL, thanks!

nodejs-github-bot · 2020-07-22T03:45:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/32466/ (:green_heart:)

joyeecheung · 2020-07-22T03:46:50Z

Custom build with --experimental-quic (pending) https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/15520/ (:green_heart:)

gengjiawen · 2020-07-22T06:31:18Z

Fast track ?

Otherwise the build would fail with `./configure --experimental-quic --ninja` as the list of per-Environment values would not match and the code cache builder would not generate code cache for the quic JS sources. This is more or less a band-aid - a proper fix would be to aggregate these flags into something that can be included by all these different binary targets. See #31074. PR-URL: #34454 Fixes: #34435 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

gengjiawen · 2020-07-22T13:37:37Z

Landed in f4f191b

Refs: #34454 PR-URL: #34460 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

Otherwise the build would fail with `./configure --experimental-quic --ninja` as the list of per-Environment values would not match and the code cache builder would not generate code cache for the quic JS sources. This is more or less a band-aid - a proper fix would be to aggregate these flags into something that can be included by all these different binary targets. See #31074. PR-URL: #34454 Fixes: #34435 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

MylesBorins · 2020-07-27T22:13:28Z

Adding don't land labels for 10.x - 14.x as this is related to quic

Refs: #34454 PR-URL: #34460 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

joyeecheung requested a review from a team July 21, 2020 01:43

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jul 21, 2020

joyeecheung added the quic Issues and PRs related to the QUIC implementation / HTTP/3. label Jul 21, 2020

addaleax added a commit to addaleax/node that referenced this pull request Jul 21, 2020

src: guard against nullptr deref in TimerWrapHandle::Stop

4d35330

Refs: nodejs#34454

addaleax mentioned this pull request Jul 21, 2020

src: guard against nullptr deref in TimerWrapHandle::Stop #34460

Closed

2 tasks

github-actions bot mentioned this pull request Jul 22, 2020

CI Relability 2020-07-22 JaneaSystems/nodejs-reliability#45

Open

5 tasks

joyeecheung force-pushed the fix-quic branch from 34a791f to 2327a99 Compare July 22, 2020 03:38

joyeecheung force-pushed the fix-quic branch from 2327a99 to e4d50ab Compare July 22, 2020 03:43

joyeecheung changed the title ~~quic: fix --experimental-quic build~~ build: define NODE_EXPERIMENTAL_QUIC in mkcodecache and node_mksnapshot Jul 22, 2020

jasnell approved these changes Jul 22, 2020

View reviewed changes

gengjiawen approved these changes Jul 22, 2020

View reviewed changes

addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Jul 22, 2020

gengjiawen closed this Jul 22, 2020

MylesBorins added dont-land-on-v10.x labels Jul 27, 2020

github-actions bot mentioned this pull request Jul 28, 2020

CI Relability 2020-07-28 JaneaSystems/nodejs-reliability#51

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

build: define NODE_EXPERIMENTAL_QUIC in mkcodecache and node_mksnapshot#34454

build: define NODE_EXPERIMENTAL_QUIC in mkcodecache and node_mksnapshot#34454
joyeecheung wants to merge 1 commit intonodejs:masterfrom
joyeecheung:fix-quic

joyeecheung commented Jul 21, 2020 •

edited

Loading

Uh oh!

nodejs-github-bot commented Jul 21, 2020

Uh oh!

joyeecheung commented Jul 21, 2020 •

edited

Loading

Uh oh!

jasnell commented Jul 21, 2020 •

edited

Loading

Uh oh!

addaleax commented Jul 21, 2020

Uh oh!

jasnell commented Jul 21, 2020

Uh oh!

joyeecheung commented Jul 22, 2020

Uh oh!

nodejs-github-bot commented Jul 22, 2020 •

edited by addaleax

Loading

Uh oh!

joyeecheung commented Jul 22, 2020 •

edited by addaleax

Loading

Uh oh!

gengjiawen commented Jul 22, 2020

Uh oh!

gengjiawen commented Jul 22, 2020

Uh oh!

MylesBorins commented Jul 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

joyeecheung commented Jul 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

build: define NODE_EXPERIMENTAL_QUIC in mkcodecache and node_mksnapshot

Revert "src: refactor TimerWrap lifetime management"

Checklist

Uh oh!

nodejs-github-bot commented Jul 21, 2020

Uh oh!

joyeecheung commented Jul 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasnell commented Jul 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

addaleax commented Jul 21, 2020

Uh oh!

jasnell commented Jul 21, 2020

Uh oh!

joyeecheung commented Jul 22, 2020

Uh oh!

nodejs-github-bot commented Jul 22, 2020 • edited by addaleax Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joyeecheung commented Jul 22, 2020 • edited by addaleax Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gengjiawen commented Jul 22, 2020

Uh oh!

gengjiawen commented Jul 22, 2020

Uh oh!

MylesBorins commented Jul 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

joyeecheung commented Jul 21, 2020 •

edited

Loading

joyeecheung commented Jul 21, 2020 •

edited

Loading

jasnell commented Jul 21, 2020 •

edited

Loading

nodejs-github-bot commented Jul 22, 2020 •

edited by addaleax

Loading

joyeecheung commented Jul 22, 2020 •

edited by addaleax

Loading