benchmark: fix EADDRNOTAVAIL error in http2#34598
benchmark: fix EADDRNOTAVAIL error in http2#34598rickyes wants to merge 1 commit intonodejs:masterfrom
Conversation
|
Not sure whether it's a good idea to lower the default value, but you can just pass |
|
I think you can also change the |
mcollina
left a comment
There was a problem hiding this comment.
On second thought I don't think this is needed.
|
Refs: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/660/console @mcollina But then we wouldn't be able to run the |
|
Or any good suggestions ? |
|
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
|
Closing this because it has stalled. Feel free to reopen if this PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions. |
Fixes: #34061
It is found that there may be errors caused by too many TCP connections. This PR is only to reduce the number of connections to avoid
benchmarktests crashing. On my macOS, when the value ofdurationis2, there will be no errors basically./cc @addaleax @BridgeAR @jasnell
Checklist