Merged
Conversation
nodejs-github-bot
added
doc
addaleax
approved these changes
Oct 10, 2020
doc/api/process.md
Outdated
Member
There was a problem hiding this comment.
Suggested change
| that started the Node.js process. Symbolic links if any, will be resolved | |
| that started the Node.js process. Symbolic links, if any, will be resolved |
Member
There was a problem hiding this comment.
In addition to the comma, I'd prefer that we keep things in present tense if there's a choice:
Suggested change
| that started the Node.js process. Symbolic links if any, will be resolved | |
| that started the Node.js process. Symbolic links, if any, are resolved |
Contributor
Author
Trott
reviewed
Oct 11, 2020
doc/api/process.md
Outdated
Comment on lines
1189
to
1190
Member
There was a problem hiding this comment.
Maybe also leave off the last three words?
Suggested change
| that started the Node.js process. Symbolic links if any, will be resolved | |
| in the pathname. | |
| that started the Node.js process. Symbolic links, if any, are resolved. |
Contributor
Author
There was a problem hiding this comment.
@Trott -Thanks. I have followed your suggestion. Please have a look.
Trott
approved these changes
Oct 11, 2020
lpinca
approved these changes
Oct 11, 2020
Trott
approved these changes
Oct 13, 2020
PR-URL: nodejs#35590 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott
force-pushed
the
process-execpath
branch
from
b8f93be to
8c177c4
Compare
Member
|
Landed in 8c177c4 |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 14, 2020
PR-URL: #35590 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #35590 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2020
PR-URL: #35590 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#35590 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes