lib: fix duplicate logic in stream destroy#35727
Closed
yashLadha wants to merge 1 commit intonodejs:masterfrom
Closed
lib: fix duplicate logic in stream destroy#35727yashLadha wants to merge 1 commit intonodejs:masterfrom
yashLadha wants to merge 1 commit intonodejs:masterfrom
Conversation
Collaborator
|
Review requested:
|
Codecov Report
@@ Coverage Diff @@
## master #35727 +/- ##
==========================================
- Coverage 96.40% 96.40% -0.01%
==========================================
Files 222 223 +1
Lines 73682 73679 -3
==========================================
- Hits 71033 71029 -4
- Misses 2649 2650 +1
Continue to review full report at Codecov.
|
lpinca
approved these changes
Oct 21, 2020
Member
|
The subsystem in commit title should be |
Fix duplicate logic in stream destroy as the same logic is being shared across methods and thus can be encapsulated into a single method.
yashLadha
force-pushed
the
fix_duplicate_logic_stream_destroy
branch
from
fb42577 to
464d7c6
Compare
Contributor
Author
|
Updated @lpinca |
gireeshpunathil
approved these changes
Oct 21, 2020
gireeshpunathil
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
ronag
approved these changes
Oct 21, 2020
gireeshpunathil
added
the
author ready
Trott
approved these changes
Oct 21, 2020
antsmartian
approved these changes
Oct 21, 2020
benjamingr
approved these changes
Oct 21, 2020
rickyes
approved these changes
Oct 22, 2020
gireeshpunathil
pushed a commit
that referenced
this pull request
Oct 24, 2020
Fix duplicate logic in stream destroy as the same logic is being shared across methods and thus can be encapsulated into a single method. PR-URL: #35727 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Member
|
landed in 4d54449 |
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
Fix duplicate logic in stream destroy as the same logic is being shared across methods and thus can be encapsulated into a single method. PR-URL: #35727 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix duplicate logic in stream destroy as the same logic is being shared
across methods and thus can be encapsulated into a single method.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes