timers: add non-boolean ref test setImmediate#35860
Closed
RaisinTen wants to merge 1 commit intonodejs:masterfrom
Closed
timers: add non-boolean ref test setImmediate#35860RaisinTen wants to merge 1 commit intonodejs:masterfrom
RaisinTen wants to merge 1 commit intonodejs:masterfrom
Conversation
Trott
approved these changes
Oct 29, 2020
Member
|
LGTM but I think it's a duplicate of #35852. |
Member
Author
|
@Trott 🤦 I forgot to check before I made the PR. Whoops! Should I close it? |
Member
In this case, yeah, probably. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a test to improve the coverage here:
node/lib/timers/promises.js
Lines 96 to 102 in bec918f
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes