doc: add link to [customizing util.inspect colors].#3748
Closed
jmm wants to merge 1 commit intonodejs:v5.xfrom
Closed
doc: add link to [customizing util.inspect colors].#3748jmm wants to merge 1 commit intonodejs:v5.xfrom
jmm wants to merge 1 commit intonodejs:v5.xfrom
Conversation
Member
|
I think you want to target the pull request against |
Contributor
|
Everything lands in |
2cb93ee to
db4b07f
Compare
Contributor
|
@jmm Could you please open a new Pull Request with the merge base / target set to |
db4b07f to
2cb93ee
Compare
Contributor
Author
|
Thanks @Trott @mikeal @Fishrock123. I actually saw that (it's right above the part that I linked to), but lost track of it obviously. Sorry about that. I pushed the original commit here again so it's not showing 56 participants anymore (I hope those people didn't get spammed as a result of that...ugh). @Fishrock123 Opened #3749. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this said "see below" to nowhere.
I have the same thing for v4.x.
Another option would be to link to the
util.inspect()documentation for all of the options (showHidden|depth|colors) instead of duplicating them (that'd be my preference, unless the build system can accomodate that content being located in one place and inserted in both places in the output).The task for building the docs depends on building Node? That is prohibitively slow for making docs changes. (I'm doing it where I already have a functioning Node installation.) I had to hack the build scripts to get around that to be able to make these changes, and I wouldn't attempt this again without being able to build them using the existing Node install. It's possible I've misunderstood or done something wrong -- I just followed the instructions from the README:
$ make doc.What does
CONTRIBUTING.mdmean?:Less strict than what?