-
-
Notifications
You must be signed in to change notification settings - Fork 35k
events: use nullish coalencing operator #38328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
619d277
events: use nullish coalencing operator
VoltrexKeyva ea4c8f7
benchmark: create ee-newlistener.js
VoltrexKeyva 507ddec
use increment assignment operator
VoltrexKeyva 5a11a92
Add a single event listener
VoltrexKeyva c32aa26
Fix benchmark
VoltrexKeyva 4540888
CI check timeout
VoltrexKeyva 7954246
Modify ee-add-remove benchmark
VoltrexKeyva File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| 'use strict'; | ||
| const common = require('../common.js'); | ||
| const EventEmitter = require('events').EventEmitter; | ||
| const MathRandom = Math.random; | ||
|
|
||
| const bench = common.createBenchmark(main, { n: [1e6] }); | ||
|
|
||
| function main({ n }) { | ||
| const ee = new EventEmitter(); | ||
| const listeners = []; | ||
|
|
||
| for (let i = 0; i < 10; i += 1) { | ||
| const listener = () => {}; | ||
| if (MathRandom() + .5) listener.listener = () => {}; | ||
| listeners.push(listener); | ||
| ee.on(`newListener${i}`, () => {}); | ||
| } | ||
|
|
||
| bench.start(); | ||
| for (let i = 0; i < n; i += 1) { | ||
| for (let k = 0; k < listeners.length; k += 1) | ||
| ee.emit(`newListener${k}`, listeners[k].listener ?? listeners[k]); | ||
| } | ||
| bench.end(n); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.