src: use SPrintF in ProcessEmitWarning

src/node_process.h

@@ -25,7 +25,10 @@ v8::Maybe<bool> ProcessEmitWarningGeneric(Environment* env,
                                           const char* type = nullptr,
                                           const char* code = nullptr);
 
-v8::Maybe<bool> ProcessEmitWarning(Environment* env, const char* fmt, ...);
+template <typename... Args>
+v8::Maybe<bool> ProcessEmitWarning(Environment* env,
+                                   const char* fmt,
+                                   Args&&... args);
 v8::Maybe<bool> ProcessEmitExperimentalWarning(Environment* env,
                                               const char* warning);
 v8::Maybe<bool> ProcessEmitDeprecationWarning(Environment* env,

src/node_process_events.cc

@@ -2,6 +2,7 @@
 #include <set>
 
 #include "env-inl.h"
+#include "debug_utils-inl.h"
 #include "node_process.h"
 #include "util.h"
 
@@ -85,15 +86,13 @@ Maybe<bool> ProcessEmitWarningGeneric(Environment* env,
 }
 
 // Call process.emitWarning(str), fmt is a snprintf() format string
-Maybe<bool> ProcessEmitWarning(Environment* env, const char* fmt, ...) {
-  char warning[1024];
-  va_list ap;
+template <typename... Args>
+v8::Maybe<bool> ProcessEmitWarning(Environment* env,
+                                   const char* fmt,
+                                   Args&&... args) {
+  std::string warning = SPrintF(fmt, std::forward<Args>(args)...);
 
-  va_start(ap, fmt);
-  vsnprintf(warning, sizeof(warning), fmt, ap);
-  va_end(ap);
-
-  return ProcessEmitWarningGeneric(env, warning);
+  return ProcessEmitWarningGeneric(env, warning.c_str());
 }