fs: add recursive cp method by bcoe · Pull Request #39372 · nodejs/node

bcoe · 2021-07-13T00:52:22Z

Introduces recursive cp method, based on fs-extra implementation

Refs: nodejs/tooling#98
Fixes: #35880

Opening to start conversation.

TODO:

still have many tests to write, to increase coverage. (coverage is at 92%).
need to document sync and promise API.

CC: @nodejs/tooling, @jprichardson, @manidlou, @RyanZim

test/parallel/test-copy.js

lib/internal/fs/copy/copy.js

lib/internal/fs/promises.js

lib/internal/fs/copy/copy.js

lib/internal/fs/copy/copy-sync.js

mcollina

lgtm

targos

Just making sure this doesn't land without documentation for the Promises and sync APIs

lib/internal/fs/copy/copy-sync.js

iansu

Looks good overall! 🙌

lib/internal/fs/promises.js

lib/internal/fs/utils.js

bcoe · 2021-07-15T15:33:13Z

@mcollina @targos small, but significant update, I thought force would be a better option than overwrite for when clobbering the destination folder, and have renamed it to this. Also, force now defaults to false.

nodejs-github-bot · 2021-07-15T15:33:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/39071/

lib/internal/fs/copy/copy-sync.js

RyanZim · 2021-07-15T19:23:23Z

I thought force would be a better option than overwrite for when clobbering the destination folder, and have renamed it to this. Also, force now defaults to false.

While we're rethinking options, should errorOnExist default to false or true? This is another one of those options that has its value for compat reasons.

RyanZim · 2021-07-15T19:27:21Z

Also, for reference; discussion thread on how fs-extra should handle the forthcoming naming conflict: jprichardson/node-fs-extra#912

aduh95

Further simplifications on the subject of replacing open + futimes + close with utimes.

lib/internal/fs/copy/copy-sync.js

lib/internal/fs/copy/copy.js

bcoe · 2021-07-15T22:06:54Z

@RyanZim @iansu

While we're rethinking options, should errorOnExist default to false or true? This is another one of those options that has its value for compat reasons.

I was tempted to go with false, which I believe would make copying to the same folder twice relatively safe, i.e., you don't clobber files, but it's less of a pain in the neck to recover from a partial copy (you don't have to lookup an option).

Thoughts?

lib/internal/fs/utils.js

doc/api/errors.md

doc/api/fs.md

lib/internal/fs/copy/copy-sync.js

lib/internal/fs/copy/copy.js

bcoe · 2021-07-22T15:06:57Z

FYI, waiting on a windows machine at work (there are some hiccups with provisioning). Would happily pair with someone on fixing up the failing windows test, if anyone has a system up and running.

Notable changes: * fs: * experimental: add recursive cp method (Benjamin Coe) #39372 PR-URL: #39782

lostpebble · 2021-08-19T08:31:49Z

Is there any place to give feedback on this function?

Just looking through the docs, I think the option force: <boolean> is a bit ambiguous and would have been better suited to be named overwrite- as that's literally what it achieves, according to the docs.

[EDIT]
Sorry, after reading further comments, I see it was actually changed from overwrite to force - which I'm a little confused about now...

bcoe · 2021-08-26T14:56:22Z

@lostpebble please feel free to open an issue. As much as possible I'd like to model after cp's flags, but perhaps clobber is the better name in this case?

One good thing about force is it's consistent with rm.

As per nodejs/node#39372 (comment) Resolves #918

As per nodejs/node#39372 (comment) Resolves jprichardson/node-fs-extra#918

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 13, 2021

bcoe commented Jul 13, 2021

View reviewed changes

test/parallel/test-copy.js Outdated Show resolved Hide resolved

bcoe commented Jul 13, 2021

View reviewed changes

lib/internal/fs/copy/copy.js Outdated Show resolved Hide resolved

bcoe commented Jul 13, 2021

View reviewed changes

lib/internal/fs/copy/copy.js Outdated Show resolved Hide resolved

bcoe force-pushed the copy branch from bb5fe4a to 4107b45 Compare July 13, 2021 01:02

This comment has been minimized.

Sign in to view

aduh95 reviewed Jul 13, 2021

View reviewed changes

mcollina approved these changes Jul 13, 2021

View reviewed changes

targos requested changes Jul 13, 2021

View reviewed changes

merceyz reviewed Jul 13, 2021

View reviewed changes

lib/internal/fs/copy/copy-sync.js Show resolved Hide resolved

This comment has been minimized.

Sign in to view

iansu reviewed Jul 14, 2021

View reviewed changes

lib/internal/fs/promises.js Outdated Show resolved Hide resolved

lib/internal/fs/utils.js Outdated Show resolved Hide resolved

bcoe added notable-change PRs with changes that should be highlighted in changelogs. semver-minor PRs that contain new features and should be released in the next minor version. labels Jul 15, 2021

aduh95 reviewed Jul 15, 2021

View reviewed changes

lib/internal/fs/copy/copy-sync.js Outdated Show resolved Hide resolved

RyanZim mentioned this pull request Jul 15, 2021

fs.cp coming to Node.js core jprichardson/node-fs-extra#912

Open

aduh95 reviewed Jul 15, 2021

View reviewed changes

lib/internal/fs/copy/copy-sync.js Outdated Show resolved Hide resolved

lib/internal/fs/copy/copy-sync.js Outdated Show resolved Hide resolved

lib/internal/fs/copy/copy.js Show resolved Hide resolved

lib/internal/fs/copy/copy.js Outdated Show resolved Hide resolved

targos reviewed Jul 16, 2021

View reviewed changes

lib/internal/fs/utils.js Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

manidlou reviewed Jul 18, 2021

View reviewed changes

bcoe force-pushed the copy branch from f94a533 to 83a403c Compare July 19, 2021 02:34

bcoe force-pushed the copy branch from 5988d2c to 86d3eeb Compare July 25, 2021 20:25

danielleadams added a commit that referenced this pull request Aug 17, 2021

2021-08-17, Version 16.7.0 (Current)

d5987f8

Notable changes: * fs: * experimental: add recursive cp method (Benjamin Coe) #39372 PR-URL: #39782

danielleadams added a commit that referenced this pull request Aug 18, 2021

2021-08-17, Version 16.7.0 (Current)

7ca38f0

Notable changes: * fs: * experimental: add recursive cp method (Benjamin Coe) #39372 PR-URL: #39782

targos added the dont-land-on-v14.x label Sep 4, 2021

theoludwig mentioned this pull request Sep 11, 2022

Stabilize fs.cp(), fs.cpSync(), fsPromises.cp() methods #44598

Closed

RyanZim added a commit to jprichardson/node-fs-extra that referenced this pull request Oct 25, 2022

Remove unneeded and buggy stats check

fe73a03

As per nodejs/node#39372 (comment) Resolves #918

RyanZim mentioned this pull request Oct 25, 2022

Remove unneeded and buggy stats check jprichardson/node-fs-extra#976

Merged

RyanZim added a commit to jprichardson/node-fs-extra that referenced this pull request Nov 19, 2022

Remove unneeded and buggy stats check (#976)

1a3205d

As per nodejs/node#39372 (comment) Resolves #918

targos mentioned this pull request Apr 24, 2024

fs: ensure return value type of options.filter in cpSync consistent with doc #52461

Closed

vrecomet added a commit to vrecomet/Metaln00b1 that referenced this pull request May 17, 2025

Remove unneeded and buggy stats check (#976)

f3940a0

As per nodejs/node#39372 (comment) Resolves jprichardson/node-fs-extra#918

baiiiiiiix pushed a commit to baiiiiiiix/Documentation that referenced this pull request May 17, 2025

Remove unneeded and buggy stats check (#976)

e42a5ad

As per nodejs/node#39372 (comment) Resolves jprichardson/node-fs-extra#918

neysidevhcr1j added a commit to neysidevhcr1j/neysidevhcr1j that referenced this pull request May 20, 2025

Remove unneeded and buggy stats check (#976)

2b9a8be

As per nodejs/node#39372 (comment) Resolves jprichardson/node-fs-extra#918

9liaswilde added a commit to 9liaswilde/robotboy6558 that referenced this pull request May 30, 2025

Remove unneeded and buggy stats check (#976)

508644a

As per nodejs/node#39372 (comment) Resolves jprichardson/node-fs-extra#918

KennetYoung added a commit to KennetYoung/ingeni that referenced this pull request Jun 10, 2025

Remove unneeded and buggy stats check (#976)

bb11f81

As per nodejs/node#39372 (comment) Resolves jprichardson/node-fs-extra#918

AnthoneTurner added a commit to AnthoneTurner/stone that referenced this pull request Jun 10, 2025

Remove unneeded and buggy stats check (#976)

dbaf0aa

As per nodejs/node#39372 (comment) Resolves jprichardson/node-fs-extra#918

Ronaldnoore added a commit to Ronaldnoore/gcs that referenced this pull request Jun 10, 2025

Remove unneeded and buggy stats check (#976)

9323885

As per nodejs/node#39372 (comment) Resolves jprichardson/node-fs-extra#918

SaurabViena pushed a commit to SaurabViena/NoneCharacter that referenced this pull request Jun 13, 2025

Remove unneeded and buggy stats check (#976)

f85159a

As per nodejs/node#39372 (comment) Resolves jprichardson/node-fs-extra#918

bugcloudLeah pushed a commit to bugcloudLeah/vert-x3 that referenced this pull request Jun 15, 2025

Remove unneeded and buggy stats check (#976)

a39daeb

As per nodejs/node#39372 (comment) Resolves jprichardson/node-fs-extra#918

FabianSili pushed a commit to FabianSili/CazaresLuisc that referenced this pull request Jun 15, 2025

Remove unneeded and buggy stats check (#976)

ca1b9ce

As per nodejs/node#39372 (comment) Resolves jprichardson/node-fs-extra#918

JosepehWilson added a commit to JosepehWilson/Xilinxa that referenced this pull request Jul 6, 2025

Remove unneeded and buggy stats check (#976)

fed0f2b

As per nodejs/node#39372 (comment) Resolves jprichardson/node-fs-extra#918

StevensBrownu added a commit to StevensBrownu/funicular that referenced this pull request Jul 8, 2025

Remove unneeded and buggy stats check (#976)

1d36e7c

As per nodejs/node#39372 (comment) Resolves jprichardson/node-fs-extra#918

TheresaMoons added a commit to TheresaMoons/KacperGierycz that referenced this pull request Jul 14, 2025

Remove unneeded and buggy stats check (#976)

50852cb

As per nodejs/node#39372 (comment) Resolves jprichardson/node-fs-extra#918

ID279184665 added a commit to ID279184665/phytochemical that referenced this pull request Jul 22, 2025

Remove unneeded and buggy stats check (#976)

e3f3f96

As per nodejs/node#39372 (comment) Resolves jprichardson/node-fs-extra#918

FeenFiction added a commit to FeenFiction/Factorization that referenced this pull request Aug 13, 2025

Remove unneeded and buggy stats check (#976)

c145b31

As per nodejs/node#39372 (comment) Resolves jprichardson/node-fs-extra#918

elizabethiAnderson added a commit to elizabethiAnderson/bordertime that referenced this pull request Sep 13, 2025

Remove unneeded and buggy stats check (#976)

216f11e

As per nodejs/node#39372 (comment) Resolves jprichardson/node-fs-extra#918

meltnoexi added a commit to meltnoexi/Telegram that referenced this pull request Oct 10, 2025

Remove unneeded and buggy stats check (#976)

2eb3aed

As per nodejs/node#39372 (comment) Resolves jprichardson/node-fs-extra#918

criticalPathway added a commit to criticalPathway/node-fs-extra that referenced this pull request Nov 17, 2025

Remove unneeded and buggy stats check (#976)

b95c1f1

As per nodejs/node#39372 (comment) Resolves jprichardson/node-fs-extra#918

setacte added a commit to setacte/SVX9000 that referenced this pull request Nov 23, 2025

Remove unneeded and buggy stats check (#976)

2174f7e

As per nodejs/node#39372 (comment) Resolves jprichardson/node-fs-extra#918

Luckaeame added a commit to Luckaeame/preliminary that referenced this pull request Dec 30, 2025

Remove unneeded and buggy stats check (#976)

7a8f938

As per nodejs/node#39372 (comment) Resolves jprichardson/node-fs-extra#918

Uh oh!

Conversation

bcoe commented Jul 13, 2021 • edited by aduh95 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

targos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

iansu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bcoe commented Jul 15, 2021

Uh oh!

nodejs-github-bot commented Jul 15, 2021

Uh oh!

Uh oh!

RyanZim commented Jul 15, 2021

Uh oh!

RyanZim commented Jul 15, 2021

Uh oh!

aduh95 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bcoe commented Jul 15, 2021

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bcoe commented Jul 22, 2021

Uh oh!

lostpebble commented Aug 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bcoe commented Aug 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

bcoe commented Jul 13, 2021 •

edited by aduh95

Loading

lostpebble commented Aug 19, 2021 •

edited

Loading