Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v14.17.4 proposal #39466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
v14.17.4 proposal #39466
Changes from 1 commit
17eb561a83b01a4be2e877fdd6eca60a9607557e74ccecea54213e978bd2a39fc219d80321c5b1da6921b172e6f22afb7c193ea8fa62826ba8924fadd2642b9e28c6c4d3a1fa99fd8bf4d9129e7d82200e265d8e8049b69846a1382c11d3e2d320316ea1368aeea252b5b1d1ff9693cf55ea29e58154cea6f8ba8826ae9beb9193286477b2504bfd78699e6201f00fa7f53a0bfecad401dc71dadfe96987a9850ab4f60bb2ec7c9db7686d02ad0719fb0ab4ce36d2a673e199db0a1984981217e0cca16a1ffbe3d2c28e00ff7cc8f4bb0bd0b2d836b9b4ae8f49a0006fc2b1ecdd005476c061d5cd3305a660a97b0736dd8b405296b6942a6bee477b8dd1f7061da3711023433d34156141fcbadc99a09fcd48ee7b3b5995547f88be474e98443db64069cf59ab28f9bafb6178797bd73dcfb18254a250e6962c6440093506f1862e43fe6c151da7d204032fa2bc2a236447cab6b2fea34c2b813a657f25199fe32b8e63b3097a787ab45acebb9a9ade7f266e1ab4f81ea9003ad4f96bbe3223ed9b6906945c2ea35039f214efefe0d8cc2ffcde722121ecee1721edef79bfb040ef5e08249acd5e58f938d74d67fb30ff35ae9075634659f2b5724a1ad80566f9a4dcb052e1c5cfccf13a3991d75d4d23d9b993edb7ee9d8716ee152ff671ed48b91eacf5279488c27fFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Original commit message: Fix implicit conversion loses integer precision warning The type of m is long in 64 bits build, and results implicit conversion loses integer precision, which was found by improved clang warning (-Wshorten-64-to-32) Bug: chromium:1124085 Change-Id: Ic9f22508bd817a06d5c90162b1ac3554a7171529 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2391323 Commit-Queue: Zequan Wu <zequanwu@google.com> Auto-Submit: Zequan Wu <zequanwu@google.com> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#69686} Refs: v8/v8@0b3a4ec PR-URL: #39244 Refs: nodejs/build#2696 Reviewed-By: Richard Lau <rlau@redhat.com>Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing