Skip to content

dns: fix uv_timer_start usage #39723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oluan wants to merge 4 commits into
base: main
Choose a base branch
from
Open

dns: fix uv_timer_start usage #39723

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6757bc0
dns: fix `uv_timer_start` usage
oluan Aug 10, 2021
32980da
test: add missing description on `test-dns-channel-tries.js`
oluan Aug 10, 2021
4953473
fixup! test allowed imprecision
oluan Aug 10, 2021
191b5c6
dns: adjust timer `repeat`
oluan Aug 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add missing description on test-dns-channel-tries.js
  • Loading branch information
@oluan
oluan committed Aug 10, 2021
commit 32980dac49c7d10e4ad39487801dd60ca78675d2
3 changes: 3 additions & 0 deletions test/parallel/test-dns-channel-tries.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ const dns = require('dns');
const TRIES = 1;
const IMPRECISION_MS = 100;

// Tests for dns.Resolver option `tries`.
// This will roughly test if a single try fails after the set `timeout`.

for (const ctor of [dns.Resolver, dns.promises.Resolver]) {
for (const tries of [null, true, false, '', '2']) {
assert.throws(() => new ctor({ tries }), {
Expand Down