meta: consolidate AUTHORS entries for alexzherdev#40620
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
meta: consolidate AUTHORS entries for alexzherdev#40620Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
meta
Member
Author
|
@alexzherdev This uses a .mailmap entry to remove your acl.com email from AUTHORS and leave your gmail.com address. If you'd prefer we do something else, please comment. Thanks! |
Contributor
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
Contributor
|
@Trott The acl.com address doesn't belong to me anymore. Could we remove it altogether? Thanks! |
Member
Author
Yes, that's what this basically does. The |
tniessen
approved these changes
Oct 27, 2021
Trott
added
the
author ready
lpinca
approved these changes
Oct 27, 2021
jasnell
approved these changes
Oct 28, 2021
jasnell
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
|
Landed in 3a74481...1306d5c |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 28, 2021
PR-URL: #40620 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 6, 2021
PR-URL: #40620 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Nov 25, 2021
PR-URL: #40620 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.