Skip to content

esm: non file baseurls and fix cache key collision #42392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bmeck wants to merge 8 commits into
base: main
Choose a base branch
from
Open

esm: non file baseurls and fix cache key collision #42392

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0cdd803
esm: fix baseURL for non-files
bmeck Mar 18, 2022
cfdd468
fixup: make import.meta properly init
bmeck Mar 18, 2022
ff4b7c0
fixup: oopsie
bmeck Mar 18, 2022
d80ab5b
fixup: oopsie
bmeck Mar 18, 2022
1513e3c
fixup: lint
bmeck Mar 18, 2022
b6b2a91
fixup: Update lib/internal/modules/esm/loader.js
bmeck Mar 21, 2022
3c518c2
fixup: review nits
bmeck Mar 21, 2022
933139e
fixup: lint
bmeck Mar 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: lint
  • Loading branch information
@bmeck
bmeck committed Mar 21, 2022
commit 933139e728bae6a5a3b2dc49cdcc53440b18ae6c
5 changes: 2 additions & 3 deletions lib/internal/modules/esm/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,9 +257,8 @@ class ESMLoader {
*/
getBaseURL(url) {
let baseURL = this.baseURLs.get(url);
// this will only be a string if it exists in the Map
// otherwise, it doesn't have a baseURL or needs to
// compute the baseURL
// This will only be a string if it exists in the Map otherwise, it
// doesn't have a baseURL or needs to compute the baseURL
if (typeof baseURL === 'string') {
return baseURL;
}
Expand Down