doc: add maintaining-webassembly.md#42660
Closed
mhdawson wants to merge 5 commits intonodejs:masterfrom
Closed
Conversation
Collaborator
|
Review requested:
|
VoltrexKeyva
reviewed
Apr 8, 2022
mhdawson
commented
Apr 8, 2022
marsonya
reviewed
Apr 10, 2022
Member
|
PR to add streaming compilation: #42701 Unfortunately, the spec only allows |
Member
Author
|
@tniessen thanks for the PR! Any chance you can review/approve this PR too? |
tniessen
approved these changes
Apr 12, 2022
Member
tniessen
left a comment
tniessen
left a comment
There was a problem hiding this comment.
Tiny nit: there is a typo in the commit message ("strategy").
Add maintaining-webassembly.md with strategy based on discussion in Next-10 mini-summit: nodejs/next-10#127 Signed-off-by: Michael Dawson <mdawson@devrus.com>
mhdawson
force-pushed
the
maintaining-wasm
branch
from
8623a8d to
3d71723
Compare
Member
Author
|
@tniessen thanks for the review, squashed and fixed the commit comment after pulling in your suggestions. |
Member
Author
|
@VoltrexMaster all of your comments should be fixed as well if you want to take another look. |
Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
cjihrig
approved these changes
Apr 21, 2022
Co-authored-by: Colin Ihrig <cjihrig@gmail.com>
Co-authored-by: Colin Ihrig <cjihrig@gmail.com>
Co-authored-by: Colin Ihrig <cjihrig@gmail.com>
Member
Author
|
@cjihrig many thanks for reviewing. |
Member
Author
|
Checks passed and doc only so landing. |
mhdawson
added a commit
that referenced
this pull request
Apr 21, 2022
Add maintaining-webassembly.md with strategy based on discussion in Next-10 mini-summit: nodejs/next-10#127 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #42660 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
Author
|
Landed in 3a6b975 |
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Apr 23, 2022
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
Add maintaining-webassembly.md with strategy based on discussion in Next-10 mini-summit: nodejs/next-10#127 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#42660 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Apr 25, 2022
Refs: #42660 Refs: #42701 PR-URL: #42836 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2022
Add maintaining-webassembly.md with strategy based on discussion in Next-10 mini-summit: nodejs/next-10#127 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #42660 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2022
Refs: #42660 Refs: #42701 PR-URL: #42836 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
Add maintaining-webassembly.md with strategy based on discussion in Next-10 mini-summit: nodejs/next-10#127 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #42660 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
Refs: #42660 Refs: #42701 PR-URL: #42836 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
Add maintaining-webassembly.md with strategy based on discussion in Next-10 mini-summit: nodejs/next-10#127 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #42660 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
Refs: #42660 Refs: #42701 PR-URL: #42836 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
Add maintaining-webassembly.md with strategy based on discussion in Next-10 mini-summit: nodejs/next-10#127 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #42660 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
Refs: #42660 Refs: #42701 PR-URL: #42836 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
Add maintaining-webassembly.md with strategy based on discussion in Next-10 mini-summit: nodejs/next-10#127 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #42660 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
Refs: #42660 Refs: #42701 PR-URL: #42836 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Add maintaining-webassembly.md with strategy based on discussion in Next-10 mini-summit: nodejs/next-10#127 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs/node#42660 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Refs: nodejs/node#42660 Refs: nodejs/node#42701 PR-URL: nodejs/node#42836 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add maintaining-webassembly.md with startegy based
on discussion in Next-10 mini-summit:
nodejs/next-10#127
Signed-off-by: Michael Dawson mdawson@devrus.com