doc: clarify core modules that can be loaded without a prefix#42753
Merged
nodejs-github-bot merged 2 commits intonodejs:masterfrom Apr 19, 2022
Merged
doc: clarify core modules that can be loaded without a prefix#42753nodejs-github-bot merged 2 commits intonodejs:masterfrom
nodejs-github-bot merged 2 commits intonodejs:masterfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
doc
Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
GeoffreyBooth
approved these changes
Apr 16, 2022
aduh95
added
the
author ready
JakobJingleheimer
approved these changes
Apr 17, 2022
Mesteery
approved these changes
Apr 17, 2022
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/42753 ✔ Done loading data for nodejs/node/pull/42753 ----------------------------------- PR info ------------------------------------ Title doc: clarify core modules that can be loaded without a prefix (#42753) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:update-docs-regarding-node-prefix -> nodejs:master Labels doc, module, author ready Commits 2 - doc: clarify core modules that can be loaded without a prefix - Update doc/api/modules.md Committers 2 - Antoine du Hamel - GitHub PR-URL: https://github.com/nodejs/node/pull/42753 Refs: https://github.com/nodejs/node/pull/42325 Reviewed-By: Geoffrey Booth Reviewed-By: Jacob Smith Reviewed-By: Mestery ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42753 Refs: https://github.com/nodejs/node/pull/42325 Reviewed-By: Geoffrey Booth Reviewed-By: Jacob Smith Reviewed-By: Mestery -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 15 Apr 2022 23:32:28 GMT ✔ Approvals: 3 ✔ - Geoffrey Booth (@GeoffreyBooth): https://github.com/nodejs/node/pull/42753#pullrequestreview-943891795 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/42753#pullrequestreview-943919035 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/42753#pullrequestreview-943983208 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 42753 From https://github.com/nodejs/node * branch refs/pull/42753/merge -> FETCH_HEAD ✔ Fetched commits as 1e761654d3d9..79261a5ba49a -------------------------------------------------------------------------------- [master ccf5bc3d7e] doc: clarify core modules that can be loaded without a prefix Author: Antoine du Hamel Date: Sat Apr 16 01:30:35 2022 +0200 1 file changed, 8 insertions(+), 5 deletions(-) [master 8d50e21ad5] Update doc/api/modules.md Author: Antoine du Hamel Date: Sat Apr 16 14:48:29 2022 +0200 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/2192673947 |
nodejs-github-bot
added
the
commit-queue-failed
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 1fe5d56 |
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
Refs: nodejs#42325 PR-URL: nodejs#42753 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Mestery <mestery@protonmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Refs: nodejs/node#42325 PR-URL: nodejs/node#42753 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Mestery <mestery@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #42325