Skip to content

build: enable V8's shared read-only heap #42809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Apr 24, 2022
Merged

build: enable V8's shared read-only heap #42809

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6132527
build: enable V8's shared read-only heap
targos Mar 18, 2022
0e7cec2
fixup! build: enable V8's shared read-only heap
targos Apr 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! build: enable V8's shared read-only heap
  • Loading branch information
@targos
targos committed Apr 22, 2022
commit 0e7cec27b0e0c928692ef5922cae1e969a7a2819
8 changes: 4 additions & 4 deletions test/parallel/test-worker-nearheaplimit-deadlock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
// Flags: --no-node-snapshot
// With node snapshot the OOM can occur during the deserialization of the
// context, so disable it since we want the OOM to occur during the creation of
// the message port.
'use strict';
const common = require('../common');
const assert = require('assert');
Expand All @@ -11,10 +15,6 @@ if (!process.env.HAS_STARTED_WORKER) {
maxYoungGenerationSizeMb: 0,
maxOldGenerationSizeMb: 0
},
// With node snapshot the OOM can occur during the deserialization of
// the context, so disable it since we want the OOM to occur during
// the creation of the message port.
execArgv: [ ...process.execArgv, '--no-node-snapshot']
};

const worker = new Worker(__filename, opts);
Expand Down