Skip to content

fs: adjust position validation in reading methods #42835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 8 commits into from
Sep 29, 2023
Merged

fs: adjust position validation in reading methods #42835

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0b4ee39
fs: adjust `position` validation in reading methods
LiviaMedeiros Apr 23, 2022
0c2bea2
squash: fix validation when `position + length` exceeds int64 limit
LiviaMedeiros Apr 23, 2022
c911c77
squash: add tests
LiviaMedeiros Apr 23, 2022
022d17c
squash: resolve todo
LiviaMedeiros May 16, 2022
39007fb
squash: add test for Promises API
LiviaMedeiros May 16, 2022
204fb4f
squash: add `changes` to docs
LiviaMedeiros Oct 11, 2022
00f9189
squash: make linter happy
LiviaMedeiros Oct 11, 2022
dc7a21e
squash: fix typo
LiviaMedeiros Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
squash: fix typo
  • Loading branch information
@LiviaMedeiros
LiviaMedeiros committed Sep 15, 2023
commit dc7a21e459c665c46167c38e4588521cf484c970
2 changes: 1 addition & 1 deletion doc/api/fs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ changes:
* `position` {integer|bigint|null} The location where to begin reading data
from the file. If `null` or `-1`, data will be read from the current file
position, and the position will be updated. If `position` is a non-negative
integer,the current file position will remain unchanged.
integer, the current file position will remain unchanged.
**Default:**: `null`
* Returns: {Promise} Fulfills upon success with an object with two properties:
* `bytesRead` {integer} The number of bytes read
Expand Down