test: mark test-cluster-primary-error as flaky on macOS#43970
test: mark test-cluster-primary-error as flaky on macOS#43970F3n67u wants to merge 1 commit intonodejs:mainfrom
Conversation
c2dd35b to
cfdf45b
Compare
|
Why on macOS? Doesn't this fail under ASan only? |
How can we mark it flaky under ASAN only? I don't know that. |
|
Maybe you could do something like node/test/parallel/test-crypto-dh-leak.js Lines 7 to 8 in 92e6342 |
That would work, but it also means little visibility of the test being skipped (as opposed to a list of flaky tests). |
Agreed 👍. I don't like this pr either. Closed. |
Refs: #39655