stream: only cleanup error listener if not readable#44304
Closed
ronag wants to merge 2 commits intonodejs:mainfrom
Closed
stream: only cleanup error listener if not readable#44304ronag wants to merge 2 commits intonodejs:mainfrom
ronag wants to merge 2 commits intonodejs:mainfrom
Conversation
Only cleanup the error listener if we know for sure that the last stream is still readable after the pipeline has completed.
Collaborator
|
Review requested:
|
Member
Author
|
@nodejs/streams |
ronag
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
16 tasks
github-actions
bot
removed
the
request-ci
Collaborator
github-actions
bot
removed
the
request-ci
Collaborator
36 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only cleanup the error listener if we know for sure that
the last stream is still readable after the pipeline has
completed.