Skip to content

tls_legacy: do not read on OpenSSL's stack #4624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
indutny wants to merge 1 commit into from
Closed

tls_legacy: do not read on OpenSSL's stack #4624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
tls_legacy: do not read on OpenSSL's stack 
Do not attempt to read data from the socket whilst on OpenSSL's stack,
weird things may happen, and this is most likely going to result in some
kind of error.
  • Loading branch information
@indutny
indutny committed Jan 11, 2016
commit 13097f14a4aa93213faa35810a349e1de9df5a48
14 changes: 8 additions & 6 deletions lib/_tls_legacy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,13 +614,15 @@ function onclienthello(hello) {

if (err) return self.socket.destroy(err);

self.ssl.loadSession(session);
self.ssl.endParser();
setImmediate(function() {
self.ssl.loadSession(session);
self.ssl.endParser();

// Cycle data
self._resumingSession = false;
self.cleartext.read(0);
self.encrypted.read(0);
// Cycle data
self._resumingSession = false;
self.cleartext.read(0);
self.encrypted.read(0);
});
}

if (hello.sessionId.length <= 0 ||
Expand Down