Merged
Conversation
nodejs-github-bot
added
dependencies
anonrig
approved these changes
Feb 26, 2023
aduh95
reviewed
Feb 26, 2023
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
The diff is suspiciously small, is the workflow working as expected? 🤔
Member
Yes, the change was related to performance counters, but its not included in the singleheader deployment of simdutf. cc @lemire |
Member
|
Right. It is a version bump that fixes a very specific issue that affected brew maintainers. |
github-actions
bot
removed
the
request-ci
Collaborator
Author
anonrig
added
the
author ready
Member
|
I guess it will be picked up again when the workflow runs. |
lpinca
approved these changes
Mar 1, 2023
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
Author
|
Landed in 55c944e |
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #46841 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
PR-URL: #46841 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #46841 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of simdutf to 3.2.2.