repl: remove lastInputPreview conditional check#46857
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Mar 1, 2023
jenthone:fix/prevent_identical_input
Merged
repl: remove lastInputPreview conditional check#46857nodejs-github-bot merged 1 commit intonodejs:mainfrom jenthone:fix/prevent_identical_input
nodejs-github-bot merged 1 commit intonodejs:mainfrom
jenthone:fix/prevent_identical_input
Conversation
nodejs-github-bot
added
needs-ci
Member
|
cc @nodejs/repl @BridgeAR |
github-actions
bot
removed
the
request-ci
Collaborator
BridgeAR
added
author ready
Collaborator
cola119
approved these changes
Mar 1, 2023
cola119
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in d0608c2 |
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #46857 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
PR-URL: #46857 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #46857 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #37585
Phenomenon: #37585 (comment)
ChromeDevTools doesn’t show a preview identical to the input as well