test_runner: fix test deserialize edge cases#48106
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom May 23, 2023
Merged
test_runner: fix test deserialize edge cases#48106nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
cjihrig
approved these changes
May 22, 2023
Contributor
|
It might be worth adding a note/label on the original PR that moved to V8 serialization that this PR should be backported with it. |
MoLow
force-pushed
the
fix-test-deserialize
branch
from
1b32632 to
e669180
Compare
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
Collaborator
MoLow
added
the
author ready
benjamingr
approved these changes
May 23, 2023
MoLow
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in f0e70ee |
This was referenced May 24, 2023
22 tasks
MoLow
added a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#48106 Fixes: nodejs#48103 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48106 Fixes: nodejs#48103 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48106 Fixes: nodejs#48103 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #48103