https: fix connection checking interval not clearing on server close by Linkgoron · Pull Request #48383 · nodejs/node

Linkgoron · 2023-06-07T19:35:55Z

The connection checking interval should get cleared when https.Server.close is called similarly to how it gets cleared when http.Server.close is called. Note that this also adds a call to closeIdleConnections() to https.server.close.

Fixes #48373

The connection interval should close when httpsServer.close is called similarly to how it gets cleared when httpServer.close is called. fixes: nodejs#48373

nodejs-github-bot · 2023-06-07T19:35:59Z

Review requested:

@nodejs/crypto
@nodejs/http
@nodejs/net

marco-ippolito

I'm not confident approving this without a test

Linkgoron · 2023-06-07T20:08:17Z

I'm not confident approving this without a test

I looked and couldn't find any tests for this specific server.close behavior. Obviously, this doesn't mean that they don't exist - If you know where they exist, or can give me some pointers on how to test this for http and https, I'd be happy to port or write them. If you have any other fears of breakage (e.g. because close is now on https.Server instead of tls.Server) I'd be happy to add any test that is missing as well.

The original intention that was approved here was to add it to https as well, but it was just an oversight that https.Server.close doesn't actually call http.Server.close.

mscdex · 2023-06-07T20:31:31Z

Shouldn't it be possible to write a minimal test based on the code in the original issue?

Linkgoron · 2023-06-07T20:51:07Z

Shouldn't it be possible to write a minimal test based on the code in the original issue?

I assumed that the question was something more functional than that. If it's just adding a test to check that the timer was cleared, it's not very difficult to check (The test would know some internals, as the timer hides behind a symbol so we'd need to expose it, but IMO it's not that bad).

ShogunPanda · 2023-06-08T09:12:10Z

I second @marco-ippolito. Code changes look fine but we need tests, thanks :)

… close

Linkgoron · 2023-06-08T10:07:17Z

added tests as requested, note that I also changed an existing test as the call to closeIdleConnections is redundant because close already calls closeIdleConnections.

MoLow

LGTM

nodejs-github-bot · 2023-06-08T10:55:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52162/

mcollina

lgtm

nodejs-github-bot · 2023-06-08T11:16:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52163/

lpinca · 2023-06-08T19:03:43Z

test/parallel/test-http-server-close-destroy-timeout.js

+const { createServer } = require('http');
+const { kConnectionsCheckingInterval } = require('_http_server');
+
+const server = createServer(function(req, res) {});


Suggested change

const server = createServer(function(req, res) {});

const server = createServer();

lpinca · 2023-06-08T19:03:58Z

test/parallel/test-https-server-close-destroy-timeout.js

+  cert: fixtures.readKey('agent1-cert.pem')
+};
+
+const server = createServer(options, function(req, res) {});


Suggested change

const server = createServer(options, function(req, res) {});

const server = createServer(options);

mcollina

lgtm awesome. I think I suffered from this bug as well.

nodejs-github-bot · 2023-06-10T20:28:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52195/

The connection interval should close when httpsServer.close is called similarly to how it gets cleared when httpServer.close is called. fixes: #48373 PR-URL: #48383 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

The connection interval should close when httpsServer.close is called similarly to how it gets cleared when httpServer.close is called. fixes: nodejs#48373 PR-URL: nodejs#48383 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

The connection interval should close when httpsServer.close is called similarly to how it gets cleared when httpServer.close is called. fixes: #48373 PR-URL: #48383 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

ruyadorno · 2023-09-12T15:05:03Z

This PR broke citgm on v18.18.0-proposal. It's going to require manual backport and citgm validation before landing on v18.x-staging again.

mcollina · 2023-09-12T15:06:04Z

How did it broke CITGM?

ruyadorno · 2023-09-12T18:04:55Z

oh sorry I forgot to add some more details, it broke fastify@4.23.0 on almost every platform (which might very much be of your interest @mcollina), here's a summary of the errors:

# Subtest: test/close-pipelining.test.js
     # Subtest: Should return 503 while closing - pipelining
         ok 1 - should be equivalent
         1..1
     ok 1 - Should return 503 while closing - pipelining # time=117.997ms
     
     # Subtest: Should not return 503 while closing - pipelining - return503OnClosing: false, skip Node >= v19.x
         not ok 1 - other side closed
           ---
           stack: |
             Socket.onSocketEnd (node_modules/undici/lib/client.js:1116:22)
           at:
             line: 1116
             column: 22
             file: node_modules/undici/lib/client.js
             function: Socket.onSocketEnd
           type: SocketError
           code: UND_ERR_SOCKET
           socket:
             localAddress: ::1
             localPort: 53232
             remoteAddress: null
             remotePort: null
             remoteFamily: null
             timeout: null
             bytesWritten: 195
             bytesRead: 376
           tapCaught: returnedPromiseRejection
           test: "Should not return 503 while closing - pipelining - return503OnClosing:
             false, skip Node >= v19.x"
           source: >2
           
               util.destroy(this, new SocketError('other side closed', util.getSocketInfo(this)))
             ---------------------^
           
             }
           ...
         
         1..1
         # failed 1 test
     not ok 2 - Should not return 503 while closing - pipelining - return503OnClosing: false, skip Node >= v19.x # time=61.927ms

     # Subtest: Current opened connection should continue to work after closing and return "connection: close" header - return503OnClosing: false, skip Node >= v19.x
         ok 1 - should not error
         ok 2 - should match pattern provided
         ok 3 - should match pattern provided
         not ok 4 - test unfinished
           ---
           stack: |
             Object.<anonymous> (test/close.test.js:207:1)
           test: 'Current opened connection should continue to work after closing and
             return "connection: close" header - return503OnClosing: false, skip Node >=
             v19.x'
           at:
             line: 207
             column: 1
             file: test/close.test.js
             function: Object.<anonymous>
           source: >
             const isV19plus = semver.gte(process.version, '19.0.0')
           
             test('Current opened connection should continue to work after closing and return "connection: close" header - return503OnClosing: false, skip Node >= v19.x', { skip: isV19plus }, t => {
           
             ^
               const fastify = Fastify({
                 return503OnClosing: false,
           ...
         
         1..4
         # failed 1 of 4 tests
     not ok 9 - Current opened connection should continue to work after closing and return "connection: close" header - return503OnClosing: false, skip Node >= v19.x # time=71.912ms

And here is the link to the full CITGM run: https://ci.nodejs.org/job/citgm-smoker/3229/

ruyadorno · 2023-09-13T01:26:28Z

it looks like it also broke undici@5.24.0 on Linux. I'm recreating the proposal without this commit and running CITGM again, you can see the results here: https://ci.nodejs.org/job/citgm-smoker/3237/

The connection interval should close when httpsServer.close is called similarly to how it gets cleared when httpServer.close is called. fixes: nodejs#48373 PR-URL: nodejs#48383 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

The connection interval should close when httpsServer.close is called similarly to how it gets cleared when httpServer.close is called. Fixes: #48373 PR-URL: #48383 Backport-PR-URL: #50194 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

kumarrishav · 2024-04-02T18:55:48Z

why have we changed the behavior in minor release? i.e Note that this also adds a call to closeIdleConnections() to https.server.close .

Is there any way to keep old behavior on v18. I completely understand and agree with adding a new method to handle it but modifying the existing one i.e server.close, it broke our app/tests.

In an environment where we own client and server, we usually keep client timeout less than server keepalive timeout and let the client know by connection:close header to handle future request. Scenario: There could be multiple stack in different language talking to each other.

related to #52330

CC: @mcollina @ShogunPanda Thoughts

Linkgoron · 2024-04-02T21:03:10Z

why have we changed the behavior in minor release? i.e Note that this also adds a call to closeIdleConnections() to https.server.close .

Is there any way to keep old behavior on v18. I completely understand and agree with adding a new method to handle it but modifying the existing one i.e server.close, it broke our app/tests.

In an environment where we own client and server, we usually keep client timeout less than server keepalive timeout and let the client know by connection:close header to handle future request. Scenario: There could be multiple stack in different language talking to each other.

related to #52330

CC: @mcollina @ShogunPanda Thoughts

This wasn't a semver-minor, it was a bug fix for a Node 19 change that was added here that missed that the added behavior to HTTP did not automatically apply to HTTPS, which was marked at the time as a semver-major.

If I'm understanding correctly, the backport to 18 has a mistake #50194, it shouldn't have added server.closeIdleConnections();. It should have only extracted the clear timeout to a "shared" method, without adding more functionality. Obviously it was not intentional (as indeed, the behavior change was originally marked as semver major). A PR would be welcome.

The connection interval should close when httpsServer.close is called similarly to how it gets cleared when httpServer.close is called. Fixes: nodejs/node#48373 PR-URL: nodejs/node#48383 Backport-PR-URL: nodejs/node#50194 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

https: fix connection checking interval not clearing on server close

af60e03

The connection interval should close when httpsServer.close is called similarly to how it gets cleared when httpServer.close is called. fixes: nodejs#48373

Linkgoron requested a review from ShogunPanda June 7, 2023 19:35

nodejs-github-bot added http Issues or PRs related to the http subsystem. https Issues or PRs related to the https subsystem. needs-ci PRs that need a full CI run. labels Jun 7, 2023

marco-ippolito reviewed Jun 7, 2023

View reviewed changes

fixup! https: fix connection checking interval not clearing on server…

d54d2aa

… close

MoLow approved these changes Jun 8, 2023

View reviewed changes

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 8, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 8, 2023

ShogunPanda approved these changes Jun 8, 2023

View reviewed changes

mcollina approved these changes Jun 8, 2023

View reviewed changes

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 8, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 8, 2023

lpinca approved these changes Jun 8, 2023

View reviewed changes

mcollina approved these changes Jun 10, 2023

View reviewed changes

ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 10, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 10, 2023

RafaelGSS mentioned this pull request Jul 3, 2023

v20.4.0 proposal #48643

Merged

trevor-scheer mentioned this pull request Jul 21, 2023

Test against Node 20, update tests for compatibility apollographql/apollo-server#7636

Merged

ruyadorno mentioned this pull request Sep 8, 2023

v18.18.0 proposal #49220

Merged

ruyadorno added the backport-requested-v18.x label Sep 12, 2023

ruyadorno mentioned this pull request Sep 12, 2023

http, https, http2: Server add Symbol.asyncDispose #48548

Closed

This was referenced Oct 15, 2023

HTTP Server close is taking up to 5 seconds in node 18 #50188

Closed

fetch will always hang up about 4s nodejs/undici#2348

Closed

H4ad mentioned this pull request Oct 16, 2023

[v18.x backport] https: fix connection checking interval not clearing on server close #50194

Closed

1 task

targos added backported-to-v18.x and removed backport-requested-v18.x labels Nov 27, 2023

targos mentioned this pull request Nov 28, 2023

v18.19.0 release proposal #50953

Merged

jsumners mentioned this pull request Dec 9, 2023

CI failure with v18.19.0 fastify/fastify#5198

Closed

kumarrishav mentioned this pull request Apr 2, 2024

[v18.x] http: remove closeIdleConnections function while calling server close #52334

Closed

michael42 mentioned this pull request Apr 26, 2024

http.server.close() closes idle connections since 18.19.0 #51677

Closed

	const server = createServer(function(req, res) {});
	const server = createServer();

	const server = createServer(options, function(req, res) {});
	const server = createServer(options);

Uh oh!

Conversation

Linkgoron commented Jun 7, 2023

Uh oh!

nodejs-github-bot commented Jun 7, 2023

Uh oh!

marco-ippolito left a comment

Choose a reason for hiding this comment

Uh oh!

Linkgoron commented Jun 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mscdex commented Jun 7, 2023

Uh oh!

Linkgoron commented Jun 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShogunPanda commented Jun 8, 2023

Uh oh!

Linkgoron commented Jun 8, 2023

Uh oh!

MoLow left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jun 8, 2023

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jun 8, 2023

Uh oh!

lpinca Jun 8, 2023

Choose a reason for hiding this comment

Uh oh!

lpinca Jun 8, 2023

Choose a reason for hiding this comment

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jun 10, 2023

Uh oh!

ruyadorno commented Sep 12, 2023

Uh oh!

mcollina commented Sep 12, 2023

Uh oh!

ruyadorno commented Sep 12, 2023

Uh oh!

ruyadorno commented Sep 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kumarrishav commented Apr 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Linkgoron commented Apr 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Linkgoron commented Jun 7, 2023 •

edited

Loading

Linkgoron commented Jun 7, 2023 •

edited

Loading

ruyadorno commented Sep 13, 2023 •

edited

Loading

kumarrishav commented Apr 2, 2024 •

edited

Loading

Linkgoron commented Apr 2, 2024 •

edited

Loading