Skip to content

esm: improve error when calling import.meta.resolve from data: URL #49516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 5 commits into from
Jan 31, 2024
Merged

esm: improve error when calling import.meta.resolve from data: URL #49516

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f2516bb
esm: improve error when calling `import.meta.resolve` from `data:` URL
aduh95 Sep 5, 2023
8c94c0e
fix lint
aduh95 Oct 21, 2023
6aa3de7
Update lib/internal/errors.js
aduh95 Jan 29, 2024
24afb0b
Apply suggestions from code review
aduh95 Jan 29, 2024
ac5dab9
Update doc/api/errors.md
aduh95 Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lib/internal/errors.js
  • Loading branch information
@aduh95
aduh95 committed Jan 31, 2024
commit 6aa3de7723ccecbc902396884bd2af6ac87efb9c
2 changes: 1 addition & 1 deletion lib/internal/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1864,7 +1864,7 @@ E('ERR_UNSUPPORTED_ESM_URL_SCHEME', (url, supported) => {
return msg;
}, Error);
E('ERR_UNSUPPORTED_RESOLVE_REQUEST',
'Failed to resolve module specifier "%s" from "%s": Invalid relative url or base scheme is not hierarchical.',
'Failed to resolve module specifier "%s" from "%s": Invalid relative URL or base scheme is not hierarchical.',
TypeError);
E('ERR_USE_AFTER_CLOSE', '%s was closed', Error);

Expand Down