test_runner: replace forEach() with for ... of

[tomhaddad]

Replaces usage of forEach() with for ... of in test-runner-mock-timers.js
#NodeConf

[nodejs-github-bot]

Review requested:

• @nodejs/test_runner

[ljharb]

why? assert.forEach isn’t the same as a for..of loop.

[atlowChemi]

Hi @tomhaddad, what is the reason for this change?
This is not a part of core in which we avoid prototype calls like forEach()

[lpinca]

@atlowChemi it's a code-and-learn exercise.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/55487/

[ljharb]

That doesn’t mean the change should just land tho, right? Or does it mean the PR isn’t going to actually land, it’s just to demonstrate how to do one?

[aduh95]

Note to reviewers: this is a test file, we do not have any requirements for how to iterate over arrays in test files, both methods are fine by me.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/55491/

[aduh95]

That doesn’t mean the change should just land tho, right? Or does it mean the PR isn’t going to actually land, it’s just to demonstrate how to do one?

As any PR, this can land after if it has approval and green CI, after the waiting time. Code and Learn consists on making low hanging fruit PRs to get a first contribution to the repo, with the hope that it will result in more contributions in the future.

Thanks for the PR @tomhaddad :)

[tomhaddad]

Thanks for the PR @tomhaddad :)

You are most welcome, happy to have made my first contribution :)

[github-actions]

Fast-track has been requested by @aduh95. Please 👍 to approve.

[nodejs-github-bot]

Landed in 8588ee1