Skip to content

src: clean up usage of __proto__ #5069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JacksonTian wants to merge 1 commit into from
Closed

src: clean up usage of __proto__ #5069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: clean up usage of __proto__ 
Prefer using Object.setPrototypeOf() instead.
  • Loading branch information
@JacksonTian
JacksonTian committed Feb 4, 2016
commit 083eee237c8216b930326a56da0f74ddc8586693
5 changes: 3 additions & 2 deletions src/node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,12 @@
function startup() {
var EventEmitter = NativeModule.require('events');

process.__proto__ = Object.create(EventEmitter.prototype, {
Object.setPrototypeOf(process, Object.create(EventEmitter.prototype, {
constructor: {
value: process.constructor
}
});
}));

EventEmitter.call(process);

process.EventEmitter = EventEmitter; // process.EventEmitter is deprecated
Expand Down