Skip to content

test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js#50795

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
StiffWriter00:test-webcrypto-sign-verify-ecdsa.js
Nov 24, 2023
Merged

test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js#50795
nodejs-github-bot merged 1 commit intonodejs:mainfrom
StiffWriter00:test-webcrypto-sign-verify-ecdsa.js

Conversation

@StiffWriter00
Copy link
Contributor

@StiffWriter00 StiffWriter00 commented Nov 18, 2023

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 18, 2023
@marco-ippolito marco-ippolito added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 18, 2023
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 20, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 20, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 20, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/55781/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 21, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/55818/

@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2023
@nodejs-github-bot nodejs-github-bot merged commit 8c72210 into nodejs:main Nov 24, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 24, 2023

Landed in 8c72210

martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
@StiffWriter00 @martenrichter
test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js
b8b8044 
PR-URL: nodejs#50795
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@StiffWriter00
test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js
247915b 
PR-URL: nodejs#50795
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Nov 27, 2023
@StiffWriter00 @RafaelGSS
test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js
46bfdf4 
PR-URL: #50795
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@StiffWriter00 @RafaelGSS
test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js
7f44164 
PR-URL: #50795
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Nov 30, 2023
@StiffWriter00 @RafaelGSS
test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js
daef3d1 
PR-URL: #50795
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@StiffWriter00 @UlisesGascon
test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js
9f5860f 
PR-URL: #50795
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 13, 2023
@StiffWriter00 @UlisesGascon
test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js
04717bd 
PR-URL: #50795
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
@StiffWriter00 @UlisesGascon
test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js
0ad36c2 
PR-URL: #50795
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@StiffWriter00 @UlisesGascon
test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js
96143a3 
PR-URL: #50795
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@StiffWriter00 @nodejs-github-bot @jasnell @lpinca @marco-ippolito @RafaelGSS