build: implement build android workflow#51666
Conversation
|
Review requested:
|
67b0286 to
0b50161
Compare
0b50161 to
d718af7
Compare
tniessen
left a comment
There was a problem hiding this comment.
All other files use the extension .yml as far as I can tell. I'd suggest renaming to build-androi.yml for consistency.
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
Co-authored-by: Tobias Nießen <tniessen@tnie.de>
You're right, it's a mistake. |
|
|
I know it shouldn't, but I'm afraid it will (it runs on |
GitHub unfortunately still does not support allowed failures (see actions/runner#2347), but perhaps one could use |
|
We can use |
The main purpose of this pull request is to advance the official support of Node.js for the Android platform. Once the goal is achieved and it becomes stable, this check should become mandatory. |
Perhaps in the short term having it be a path-based Action? Would allow a smaller number of PRs that have it as a check as a way to warm up to having it on all PRs. |
|
Maybe label is a better idea? We label PRs when if it fit to run Android build test. |
I guess there doesn't seem to be a clear definition of paths, we don't know what paths are available to run Android build tests in particular. |
Experimental activation of CI Workflow for building on the Android platform.