Skip to content

deps: update V8 to 12.5 #52651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 13 commits into from
Closed

deps: update V8 to 12.5 #52651

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f858c06
deps: update V8 to 12.5.227.11
targos May 22, 2024
0ad8983
build: reset embedder string to "-node.0"
targos May 22, 2024
dfcd625
src: update NODE_MODULE_VERSION to 128
targos Apr 23, 2024
4a5a02c
deps: always define V8_EXPORT_PRIVATE as no-op
targos Sep 21, 2022
a587ee2
deps: disable V8 concurrent sparkplug compilation
targos Apr 6, 2023
09dc20f
deps: avoid compilation error with ASan
targos Jul 31, 2023
08a5a6e
deps: patch V8 to avoid duplicated zlib symbol
targos Sep 16, 2023
3e32704
deps: silence internal V8 deprecation warning
targos Mar 11, 2024
1d3b542
deps: patch V8 to support compilation with MSVC
StefanStojanovic Apr 21, 2024
109f93e
deps: V8: revert CL 5331688
targos Apr 21, 2024
400edfa
deps: V8: cherry-pick f6bef09b3b0a
richardlau May 3, 2024
94456fc
build: include v8-sandbox.h header in distribution
targos Apr 7, 2024
e7b72f0
src: do not use deprecated V8 API
isheludko Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: avoid compilation error with ASan 
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221
PR-URL: #49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@targos
targos committed May 22, 2024
commit 09dc20f9db22718c0a6de72f8f9669c6c8d39a23
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.2',
'v8_embedder_string': '-node.3',

##### V8 defaults for Node.js #####

Expand Down
24 changes: 12 additions & 12 deletions deps/v8/src/objects/object-macros.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,24 +697,24 @@
#define WRITE_BARRIER(object, offset, value)
#define WRITE_BARRIER_CPP(object, offset, value)
#else
#define WRITE_BARRIER(object, offset, value) \
do { \
DCHECK_NOT_NULL(GetHeapFromWritableObject(object)); \
static_assert(kTaggedCanConvertToRawObjects); \
CombinedWriteBarrier(object, Tagged(object)->RawField(offset), value, \
UPDATE_WRITE_BARRIER); \
#define WRITE_BARRIER(object, offset, value) \
do { \
DCHECK_NOT_NULL(GetHeapFromWritableObject(object)); \
static_assert(kTaggedCanConvertToRawObjects); \
CombinedWriteBarrier(object, (object)->RawField(offset), value, \
UPDATE_WRITE_BARRIER); \
} while (false)
#endif

#ifdef V8_DISABLE_WRITE_BARRIERS
#define WEAK_WRITE_BARRIER(object, offset, value)
#else
#define WEAK_WRITE_BARRIER(object, offset, value) \
do { \
DCHECK_NOT_NULL(GetHeapFromWritableObject(object)); \
static_assert(kTaggedCanConvertToRawObjects); \
CombinedWriteBarrier(object, Tagged(object)->RawMaybeWeakField(offset), \
value, UPDATE_WRITE_BARRIER); \
#define WEAK_WRITE_BARRIER(object, offset, value) \
do { \
DCHECK_NOT_NULL(GetHeapFromWritableObject(object)); \
static_assert(kTaggedCanConvertToRawObjects); \
CombinedWriteBarrier(object, (object)->RawMaybeWeakField(offset), value, \
UPDATE_WRITE_BARRIER); \
} while (false)
#endif

Expand Down