deps: enable unbundling of simdjson, simdutf, ada by lemire · Pull Request #52924 · nodejs/node

lemire · 2024-05-09T19:07:45Z

When building Node.js, it is possible to replace most dependencies by locally provided ones. However, it does not apply for at least three dependencies: simdjson, simdutf, ada. This PR seeks to enable this possibility.

Fixes #52914

lemire · 2024-05-09T19:08:40Z

cc @williamh

anonrig · 2024-05-09T19:13:35Z

cc @nodejs/build @richardlau

richardlau

I'm assuming the default libnames are the same as the * part of the --shared-*-libname pattern. Please amend accordingly if not. They're almost certainly not likely to be z 🙂.

configure.py

williamh · 2024-05-09T20:20:24Z

Is it possible to add ngtcp2 to this pr, or should that be done in another pr?
Thanks much

Co-authored-by: Richard Lau <rlau@redhat.com>

lemire · 2024-05-09T20:22:38Z

@williamh My reading of the code is that ngtcp2 can be made unbundled right now. But gentoo does not choose to do so. I think @jasnell did add this feature already.

williamh · 2024-05-09T20:25:52Z

Ok, thanks for this info, I'll take a look at my side again.

nodejs-github-bot · 2024-05-09T21:08:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59068/

nodejs-github-bot · 2024-05-11T19:16:27Z

Landed in d78537b

PR-URL: #52924 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

PR-URL: nodejs#52924 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

The --shared-ada flag was introduced in nodejs#52924, but the implementation was incomplete. Resolves nodejs#52914

The --shared-simdjson flag was introduced in nodejs#52924, but the implementation was incomplete. Resolves nodejs#52914

The --shared-simdutf flag was introduced in nodejs#52924, but the implementation was incomplete. Resolves nodejs#52914

The --shared-ada flag was introduced in nodejs#52924, but the implementation was incomplete. Resolves nodejs#52914

The --shared-simdjson flag was introduced in nodejs#52924, but the implementation was incomplete. Resolves nodejs#52914

The --shared-simdutf flag was introduced in nodejs#52924, but the implementation was incomplete. Resolves nodejs#52914

The --shared-ada flag was introduced in #52924, but the implementation was incomplete. Resolves #52914 PR-URL: #55886 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

The --shared-simdjson flag was introduced in #52924, but the implementation was incomplete. Resolves #52914 PR-URL: #55886 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

The --shared-simdutf flag was introduced in #52924, but the implementation was incomplete. Resolves #52914 PR-URL: #55886 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

The --shared-ada flag was introduced in nodejs#52924, but the implementation was incomplete. Resolves nodejs#52914 PR-URL: nodejs#55886 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

The --shared-simdjson flag was introduced in nodejs#52924, but the implementation was incomplete. Resolves nodejs#52914 PR-URL: nodejs#55886 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

The --shared-simdutf flag was introduced in nodejs#52924, but the implementation was incomplete. Resolves nodejs#52914 PR-URL: nodejs#55886 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>