Skip to content

test_runner: ensure test watcher picks up new test files #54225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 17 commits into from
Aug 29, 2024
Merged

test_runner: ensure test watcher picks up new test files #54225

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
6eb7fe4
test_runner: ensure test watcher picks up new test files
pmarchini Aug 26, 2024
e30be92
test_runner: remove setMaxListeners
pmarchini Aug 26, 2024
ddd60bf
test_runner: add new test file scenario into test-runner-watch
pmarchini Aug 26, 2024
4e1f299
test_runner: remove additional filesWatcher
pmarchini Aug 26, 2024
1a9e811
test_runner: prevent rerunning deleted files
pmarchini Aug 26, 2024
c92ed73
test_runner: add support for eventType change on Linux
pmarchini Aug 26, 2024
eb10496
test_runner: add `cwd` option and update documentation
pmarchini Aug 26, 2024
8951dd2
test_runner: update tests
pmarchini Aug 26, 2024
5a57282
test_runner: correctly resolve test paths when a different cwd is pas…
pmarchini Aug 26, 2024
43cb418
test_runner: apply suggestions
pmarchini Aug 26, 2024
2621c91
test_runner: always resolve paths
pmarchini Aug 26, 2024
387e1b0
test_runner: fix paths resolution
pmarchini Aug 26, 2024
8c38fd2
test_runner: fix doc
pmarchini Aug 26, 2024
4061176
test: remove reporter specific assertions
pmarchini Aug 26, 2024
32150f6
test_runner: spawn test process with correct cwd
pmarchini Aug 26, 2024
4310da8
test: remove unnecessary whitespace
pmarchini Aug 26, 2024
67f8998
test_runner: remove cwd option
pmarchini Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: remove reporter specific assertions
  • Loading branch information
@pmarchini
pmarchini committed Aug 26, 2024
commit 406117618c352a39379c41e9ea042ec2f39f137e
34 changes: 17 additions & 17 deletions test/parallel/test-runner-run-watch.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ async function testWatch({ fileToUpdate, file, action = 'update', cwd = tmpdir.p
child.stdout.on('data', (data) => {
stdout += data.toString();
currentRun += data.toString();
const testRuns = stdout.match(/# duration_ms\s\d+/g);
const testRuns = stdout.match(/ duration_ms\s\d+/g);
if (testRuns?.length >= 1) ran1.resolve();
if (testRuns?.length >= 2) ran2.resolve();
});
Expand All @@ -78,10 +78,10 @@ async function testWatch({ fileToUpdate, file, action = 'update', cwd = tmpdir.p

for (const run of runs) {
assert.doesNotMatch(run, /run\(\) is being called recursively/);
assert.match(run, /# tests 1/);
assert.match(run, /# pass 1/);
assert.match(run, /# fail 0/);
assert.match(run, /# cancelled 0/);
assert.match(run, / tests 1/);
assert.match(run, / pass 1/);
assert.match(run, / fail 0/);
assert.match(run, / cancelled 0/);
}
};

Expand All @@ -101,21 +101,21 @@ async function testWatch({ fileToUpdate, file, action = 'update', cwd = tmpdir.p
assert.strictEqual(runs.length, 2);

const [firstRun, secondRun] = runs;
assert.match(firstRun, /# tests 1/);
assert.match(firstRun, /# pass 1/);
assert.match(firstRun, /# fail 0/);
assert.match(firstRun, /# cancelled 0/);
assert.match(firstRun, / tests 1/);
assert.match(firstRun, / pass 1/);
assert.match(firstRun, / fail 0/);
assert.match(firstRun, / cancelled 0/);
assert.doesNotMatch(firstRun, /run\(\) is being called recursively/);

if (action === 'rename2') {
assert.match(secondRun, /MODULE_NOT_FOUND/);
return;
}

assert.match(secondRun, /# tests 1/);
assert.match(secondRun, /# pass 1/);
assert.match(secondRun, /# fail 0/);
assert.match(secondRun, /# cancelled 0/);
assert.match(secondRun, / tests 1/);
assert.match(secondRun, / pass 1/);
assert.match(secondRun, / fail 0/);
assert.match(secondRun, / cancelled 0/);
assert.doesNotMatch(secondRun, /run\(\) is being called recursively/);
};

Expand Down Expand Up @@ -163,10 +163,10 @@ async function testWatch({ fileToUpdate, file, action = 'update', cwd = tmpdir.p
await once(child, 'exit');

for (const run of runs) {
assert.match(run, /# tests 1/);
assert.match(run, /# pass 1/);
assert.match(run, /# fail 0/);
assert.match(run, /# cancelled 0/);
assert.match(run, / tests 1/);
assert.match(run, / pass 1/);
assert.match(run, / fail 0/);
assert.match(run, / cancelled 0/);
}
};

Expand Down
8 changes: 4 additions & 4 deletions test/parallel/test-runner-watch-mode.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,10 +151,10 @@ async function testWatch({
await once(child, 'exit');

for (const run of runs) {
assert.match(run, /# tests 1/);
assert.match(run, /# pass 1/);
assert.match(run, /# fail 0/);
assert.match(run, /# cancelled 0/);
assert.match(run, / tests 1/);
assert.match(run, / pass 1/);
assert.match(run, / fail 0/);
assert.match(run, / cancelled 0/);
}
};

Expand Down