module: add --experimental-transform-types flag by marco-ippolito · Pull Request #54283 · nodejs/node

marco-ippolito · 2024-08-09T10:34:51Z

With the new flag --experimental-transform-types it is possible to enable the transformation of TypeScript-only syntax into JavaScript code.
This feature allows Node.js to support TypeScript syntax such as Enum and namespace.

nodejs-github-bot · 2024-08-09T10:34:57Z

Review requested:

@nodejs/loaders
@nodejs/typescript

mcollina

lgtm

doc/api/cli.md

legendecas

Can we also add a test case that --experimental-enable-transformation doesn't eliminate unused imports, like this example?

test/fixtures/typescript/ts/transformation/test-unused-import.ts

doc/api/cli.md

mcollina

Actually, on closer look I have a change request: I think --experimental-enable-type-transform should imply --enable-source-maps.

(I'm +1 on the feature)

marco-ippolito · 2024-08-09T13:39:23Z

Actually, on closer look I have a change request: I think --experimental-enable-type-transform should imply --enable-source-maps.

(I'm +1 on the feature)

Probably makes more sense, otherwise location will be always wrong

doc/api/typescript.md

nodejs-github-bot · 2024-08-12T13:07:51Z

Landed in 0301309

statianzo · 2024-08-12T16:47:22Z

Has there been discussion around writing out the result of typescript transformation?

It would allow package creators to publish TS -> JS consistent with the transformations node is doing internally. Given transformations don't apply to node_modules, packages authored using TS will require additional tooling to apply before the ability to publish. If publishers opt for tsc it wouldn't exactly match the calling the .ts from node directly.

Happy to post this comment elsewhere if more suitable.

marco-ippolito · 2024-08-12T17:25:08Z

Has there been discussion around writing out the result of typescript transformation?

It would allow package creators to publish TS -> JS consistent with the transformations node is doing internally. Given transformations don't apply to node_modules, packages authored using TS will require additional tooling to apply before the ability to publish. If publishers opt for tsc it wouldn't exactly match the calling the .ts from node directly.

Happy to post this comment elsewhere if more suitable.

We have a repository for this kind of discussion nodejs/typescript

Bnaya · 2024-08-13T10:47:14Z

Sorry if i'm later to the party :)
Does it supports only the features that are supported by typescript's isolatedModules, or also the cross-file features?

jakebailey · 2024-08-13T15:50:33Z

No, this is just isolatedModules. Node.js is not shipping a type checker that can perform that kind of analysis.

PR-URL: #54283 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>

targos · 2024-08-14T07:42:24Z

I optimistically pushed it to v22.x-staging but tests failed, so I took it out: https://github.com/nodejs/node/actions/runs/10382663326/job/28746123871

marco-ippolito · 2024-08-14T13:11:02Z

I optimistically pushed it to v22.x-staging but tests failed, so I took it out: https://github.com/nodejs/node/actions/runs/10382663326/job/28746123871

It requires backport I think, to imply the experimental-detect-module

PR-URL: nodejs#54283 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>

PR-URL: #54283 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>

Notable changes: buffer: * use fast API for writing one-byte strings (Robert Nagy) #54311 * optimize createFromString (Robert Nagy) #54324 * use native copy impl (Robert Nagy) #54087 inspector: * (SEMVER-MINOR) support `Network.loadingFailed` event (Kohei Ueno) #54246 lib: * (SEMVER-MINOR) rewrite AsyncLocalStorage without async_hooks (Stephen Belanger) #48528 module: * (SEMVER-MINOR) add --experimental-transform-types flag (Marco Ippolito) #54283 * (SEMVER-MINOR) unflag detect-module (Geoffrey Booth) #53619 PR-URL: #54452

PR-URL: #54283 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>

Notable changes: buffer: * use fast API for writing one-byte strings (Robert Nagy) #54311 * optimize createFromString (Robert Nagy) #54324 * use native copy impl (Robert Nagy) #54087 inspector: * (SEMVER-MINOR) support `Network.loadingFailed` event (Kohei Ueno) #54246 lib: * (SEMVER-MINOR) rewrite AsyncLocalStorage without async_hooks (Stephen Belanger) #48528 module: * (SEMVER-MINOR) add --experimental-transform-types flag (Marco Ippolito) #54283 * (SEMVER-MINOR) unflag detect-module (Geoffrey Booth) #53619 PR-URL: #54452

marco-ippolito changed the title ~~module: add --experimental-enable-transformation for strip-types~~ [WIP] module: add --experimental-enable-transformation for strip-types Aug 9, 2024

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Aug 9, 2024

marco-ippolito added wip Issues and PRs that are still a work in progress. strip-types Issues or PRs related to strip-types support labels Aug 9, 2024

benjamingr approved these changes Aug 9, 2024

View reviewed changes

marco-ippolito force-pushed the feat/enable-transformations branch from 29040a6 to c5da92e Compare August 9, 2024 11:20

marco-ippolito marked this pull request as ready for review August 9, 2024 11:20

marco-ippolito changed the title ~~[WIP] module: add --experimental-enable-transformation for strip-types~~ module: add --experimental-enable-transformation for strip-types Aug 9, 2024

marco-ippolito removed the wip Issues and PRs that are still a work in progress. label Aug 9, 2024

mcollina approved these changes Aug 9, 2024

View reviewed changes

marco-ippolito commented Aug 9, 2024

View reviewed changes

doc/api/cli.md Outdated Show resolved Hide resolved

marco-ippolito added the semver-minor PRs that contain new features and should be released in the next minor version. label Aug 9, 2024

marco-ippolito force-pushed the feat/enable-transformations branch 2 times, most recently from de62233 to 7343717 Compare August 9, 2024 12:15

legendecas reviewed Aug 9, 2024

View reviewed changes

doc/api/cli.md Outdated Show resolved Hide resolved

legendecas reviewed Aug 9, 2024

View reviewed changes

marco-ippolito force-pushed the feat/enable-transformations branch from 7343717 to b67230f Compare August 9, 2024 12:58

marco-ippolito commented Aug 9, 2024

View reviewed changes

test/fixtures/typescript/ts/transformation/test-unused-import.ts Show resolved Hide resolved

khaosdoctor reviewed Aug 9, 2024

View reviewed changes

doc/api/cli.md Outdated Show resolved Hide resolved

marco-ippolito force-pushed the feat/enable-transformations branch from b67230f to e0ac82e Compare August 9, 2024 13:27

khaosdoctor approved these changes Aug 9, 2024

View reviewed changes

marco-ippolito force-pushed the feat/enable-transformations branch from e0ac82e to 3578d86 Compare August 9, 2024 13:35

marco-ippolito changed the title ~~module: add --experimental-enable-transformation for strip-types~~ module: add --experimental-enable--type-transform for strip-types Aug 9, 2024

marco-ippolito changed the title ~~module: add --experimental-enable--type-transform for strip-types~~ module: add --experimental-enable-type-transform for strip-types Aug 9, 2024

marco-ippolito force-pushed the feat/enable-transformations branch from 3578d86 to 6b155bd Compare August 9, 2024 13:37

mcollina requested changes Aug 9, 2024

View reviewed changes

aduh95 reviewed Aug 9, 2024

View reviewed changes

doc/api/typescript.md Show resolved Hide resolved

marco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 12, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 12, 2024

nodejs-github-bot merged commit 0301309 into nodejs:main Aug 12, 2024

RyanCavanaugh mentioned this pull request Aug 12, 2024

Tsconfig option to disallow features requiring transformations which are not supported by Node.js' --strip-types microsoft/TypeScript#59601

Closed

6 tasks

targos added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label Aug 14, 2024

marco-ippolito mentioned this pull request Aug 14, 2024

[v22.x] Backport: "module: add --experimental-transform-types flag" #54373

Closed

justinfagnani mentioned this pull request Aug 15, 2024

Design Meeting Notes, 8/13/2024 microsoft/TypeScript#59624

Closed

allisonkarlitskaya mentioned this pull request Aug 16, 2024

Build Arm64 cockpit-project/cockpit-files#609

Closed

marco-ippolito removed the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label Aug 19, 2024

RafaelGSS mentioned this pull request Aug 20, 2024

v22.7.0 proposal #54452

Merged

marco-ippolito mentioned this pull request Aug 20, 2024

lib: expose tsParse as util.stripTypescriptTypes #54250

Closed

ShenHongFei mentioned this pull request Sep 3, 2024

Use the compilation cache when running typescript files through --experimental-transform-types #54741

Closed

targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024

karlhorky mentioned this pull request Aug 6, 2025

Change Request: Remove unstable_native_nodejs_ts_config after Node.js v22.18.0 / v24.3.0 eslint/eslint#19985

Closed

1 task

wagenet mentioned this pull request Oct 16, 2025

Inaccurate Decorator Status Documentation #60282

Closed

Uh oh!

Conversation

marco-ippolito commented Aug 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Aug 9, 2024

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

legendecas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mcollina left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marco-ippolito commented Aug 9, 2024

Uh oh!

Uh oh!

nodejs-github-bot commented Aug 12, 2024

Uh oh!

statianzo commented Aug 12, 2024

Uh oh!

marco-ippolito commented Aug 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Bnaya commented Aug 13, 2024

Uh oh!

jakebailey commented Aug 13, 2024

Uh oh!

targos commented Aug 14, 2024

Uh oh!

marco-ippolito commented Aug 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

marco-ippolito commented Aug 9, 2024 •

edited

Loading

mcollina left a comment •

edited

Loading

marco-ippolito commented Aug 12, 2024 •

edited

Loading