Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
133ad16
module: add `findPackageJSON` util
JakobJingleheimer Oct 15, 2024
1c80d6d
fixup!: `DeserializedPackageConfig`
JakobJingleheimer Oct 15, 2024
746a88c
fixup!: handle CJS & relative specifiers
JakobJingleheimer Oct 16, 2024
ec853c7
fixup!: tidy
JakobJingleheimer Oct 16, 2024
1742549
fixup!: enable Antoine's test-case
JakobJingleheimer Oct 16, 2024
0bf17ca
fixup!: throw on unexpected error
JakobJingleheimer Oct 16, 2024
acc2104
fixup!: correct test-case inputs (`parentURL` can't be a dir)
JakobJingleheimer Oct 16, 2024
12a722f
fixup!: correct conflict resolution
JakobJingleheimer Oct 16, 2024
7568d49
fixup!: tidy
JakobJingleheimer Oct 16, 2024
20db90f
fixup!: add `text` to fenced codebock
JakobJingleheimer Oct 17, 2024
b4be705
fixup!: code review improvements
JakobJingleheimer Oct 17, 2024
54c4ad2
fixup!: avoid premature `URL` → string conversion
JakobJingleheimer Oct 17, 2024
913116b
fixup!: document when pjson is not found
JakobJingleheimer Oct 17, 2024
2266258
fixup!: rename test various for clarity
JakobJingleheimer Oct 17, 2024
6cb9ddd
Apply suggestions from code review
aduh95 Oct 17, 2024
10b27b1
add a third argument to get the package scope pjson
aduh95 Oct 18, 2024
ed6e1d1
implement suggestion
aduh95 Oct 19, 2024
8397d22
fixup!: de-lint
JakobJingleheimer Oct 22, 2024
1cd6d65
fixup!: windows
JakobJingleheimer Oct 22, 2024
563cbc0
fixup!: wordsmith test-case description
JakobJingleheimer Oct 22, 2024
a06a1b3
fixup!: de-lint
JakobJingleheimer Oct 22, 2024
08fb0e2
fixup!: correct suggestion
JakobJingleheimer Oct 22, 2024
fb7d379
fixup!: de-lint
JakobJingleheimer Oct 22, 2024
073fcaa
fixup!: windows paths 😩
JakobJingleheimer Oct 23, 2024
6783f64
fixup!: readability
JakobJingleheimer Oct 23, 2024
2a1aad1
fixup!: more windows paths
JakobJingleheimer Oct 23, 2024
ef16d22
fixup!: more windows pathing
JakobJingleheimer Oct 24, 2024
31491f9
fixup!: de-lint
JakobJingleheimer Oct 24, 2024
ba9acf9
fixup!: b0rked conflict resolution
JakobJingleheimer Oct 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup!: windows paths 😩
  • Loading branch information
JakobJingleheimer committed Oct 24, 2024
commit 073fcaaf7ff9c006c985df6022c7966c09ef3819
5 changes: 3 additions & 2 deletions test/parallel/test-find-package-json.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ const tmpdir = require('../common/tmpdir');
const assert = require('node:assert');
const fs = require('node:fs');
const { findPackageJSON } = require('node:module');
const path = require('node:path');
const { describe, it } = require('node:test');


Expand All @@ -31,7 +32,7 @@ describe('findPackageJSON', () => { // Throws when no arguments are provided
const specifierBase = './packages/root-types-field/';
assert.strictEqual(
findPackageJSON(`${specifierBase}index.js`, importMetaUrl),
fixtures.path(specifierBase, 'package.json'),
path.toNamespacedPath(fixtures.path(specifierBase, 'package.json')),
);
});

Expand All @@ -43,7 +44,7 @@ describe('findPackageJSON', () => { // Throws when no arguments are provided
new URL(`${specifierBase}/index.js`, importMetaUrl),
importMetaUrl,
),
fixtures.path(specifierBase, 'package.json'),
path.toNamespacedPath(fixtures.path(specifierBase, 'package.json')),
);
});

Expand Down